Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Implement displaying of waiter message in sync-UI #2227

Closed
AlexeyBarabash opened this issue Nov 23, 2018 · 1 comment
Closed

Implement displaying of waiter message in sync-UI #2227

AlexeyBarabash opened this issue Nov 23, 2018 · 1 comment

Comments

@AlexeyBarabash
Copy link
Contributor

Description

Initialization of sync takes a time, usually 2..7 seconds.

Currently during this time the popup dialog is on the page and nothing happens.

It would be good to let the user know that 'operation is in progress' , like:

  1. show yet another popup blocking the page
    or
  2. disable controls on current popup and show some message on popup
    or
  3. some other cool way.

The waiter message should be shown between these points:
A) chrome.send('setupSyncHaveCode', ...) or
chrome.send('setupSyncNewToSync'
B) function syncSetupError(error: string) or
function showSettings (settings: any, devices: any)

Steps to Reproduce

  1. Create sync chain on one device 1
  2. Connect device 2 to sync chain with code words
  3. While it does processing should be displayed waiter message

Brave version (brave://version info)

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
    yes

Additional Information

Related issue #2130

@cezaraugusto
Copy link
Contributor

thanks @AlexeyBarabash I'm closing this in favor of #2567

@bbondy bbondy modified the milestones: 1.x Backlog, dupe/in, Dupe / Invalid / Not actionable Dec 20, 2018
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
@rebron rebron moved this to Untriaged backlog in Sync - All platforms Jul 23, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants