-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
improve error flow for Tipping #2453
Labels
Comments
A different idea that @NejcZdovc had was to possibly show the tip as pending in Tips panel (not Rewards Summary) with a Retry button instead of the notification. |
LOL you open the issue now it works!! But yes the returned error if any should be displayed in the tipping list with a retry button or some thing |
+1 from #2937 (comment) |
closing as we will fix it here #3052 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Description
Currently if your tip cannot be completed for whatever reason, we don't show anything to the user because we have retry logic and we will just retry the tip later. However, the user has no indication that the tip can't go thru and may try multiple times, which when the retry logic kicks in and the tip can be completed, will result in multiple tips being deducted from their wallet.
Steps to Reproduce
Actual result:
Tip doesn't go thru. There is no notification to the user that we couldn't complete the tip and will try again later, so the user tries multiple times.
Expected result:
When tip cannot be completed, show notification to user indicating that tip could not go thru at this time and we will try again later.
Reproduces how often:
Easily when UGP server has problem (intentional or otherwise)
Brave version (brave://version info)
Reproducible on current release:
Website problems only:
Additional Information
cc @davidtemkin @kjozwiak @NejcZdovc
The text was updated successfully, but these errors were encountered: