Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

improve error flow for Tipping #2453

Closed
LaurenWags opened this issue Dec 11, 2018 · 4 comments
Closed

improve error flow for Tipping #2453

LaurenWags opened this issue Dec 11, 2018 · 4 comments
Assignees
Labels
closed/duplicate Issue has already been reported closed/invalid

Comments

@LaurenWags
Copy link
Member

Description

Currently if your tip cannot be completed for whatever reason, we don't show anything to the user because we have retry logic and we will just retry the tip later. However, the user has no indication that the tip can't go thru and may try multiple times, which when the retry logic kicks in and the tip can be completed, will result in multiple tips being deducted from their wallet.

Steps to Reproduce

  1. Have a wallet funded with UGP.
  2. Attempt to tip during a time when server has some issue (intentional or otherwise).

Actual result:

Tip doesn't go thru. There is no notification to the user that we couldn't complete the tip and will try again later, so the user tries multiple times.

Expected result:

When tip cannot be completed, show notification to user indicating that tip could not go thru at this time and we will try again later.

Reproduces how often:

Easily when UGP server has problem (intentional or otherwise)

Brave version (brave://version info)

Brave 0.58.11 Chromium: 71.0.3578.80 (Official Build) beta(64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Mac OS X

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds? Yes, reproduced on Release version and Beta versions.

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Additional Information

cc @davidtemkin @kjozwiak @NejcZdovc

@LaurenWags LaurenWags added this to the 1.x Backlog milestone Dec 11, 2018
@LaurenWags
Copy link
Member Author

A different idea that @NejcZdovc had was to possibly show the tip as pending in Tips panel (not Rewards Summary) with a Retry button instead of the notification.

@kiwina
Copy link

kiwina commented Dec 11, 2018

LOL you open the issue now it works!! But yes the returned error if any should be displayed in the tipping list with a retry button or some thing

@mandar-brave mandar-brave added priority/P2 A bad problem. We might uplift this to the next planned release. priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P2 A bad problem. We might uplift this to the next planned release. labels Dec 14, 2018
@LaurenWags
Copy link
Member Author

+1 from #2937 (comment)

@NejcZdovc NejcZdovc added priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Jan 19, 2019
@NejcZdovc NejcZdovc self-assigned this Jan 22, 2019
@NejcZdovc
Copy link
Contributor

closing as we will fix it here #3052

@NejcZdovc NejcZdovc modified the milestones: 1.x Backlog, Dupe / Invalid / Not actionable Jan 22, 2019
@NejcZdovc NejcZdovc added closed/duplicate Issue has already been reported and removed priority/P2 A bad problem. We might uplift this to the next planned release. labels Jan 22, 2019
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
closed/duplicate Issue has already been reported closed/invalid
Projects
None yet
Development

No branches or pull requests

6 participants