Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Brave News: show 15 sources in Suggestions list #26598

Closed
mattmcalister opened this issue Nov 7, 2022 · 5 comments · Fixed by brave/brave-core#16790
Closed

Brave News: show 15 sources in Suggestions list #26598

mattmcalister opened this issue Nov 7, 2022 · 5 comments · Fixed by brave/brave-core#16790
Assignees
Labels
feature/brave-news formerly brave-today OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass-macOS QA/Yes release-notes/exclude

Comments

@mattmcalister
Copy link

As noted by @LorenzoMinto the precision of the suggestions declines the further you scroll down. So, let's reduce the number presented to the user to 15 sources in total.

@kjozwiak
Copy link
Member

@mattmcalister assuming this is referring to Brave News v2? If that's the case, then this is blocked on Android until we enable the feature via 1.50.x and then make a decision re: uplifting into 1.49.x. We're still waiting on @deeppandya to enable Brave News v2 on 1.50.x. If we decide to let it ride the trains via 1.50.x, this will be a QA/No for Android and the feature will get verified as a whole via 1.50.x.

@fallaciousreasoning
Copy link

This one was particularly for desktop I think - we were showing all the suggestions & now we limit it to 15. If we do the same on Android once the feature is enabled I think that should be fine.

@mattmcalister
Copy link
Author

not a problem. it's a UX enhancement, happy for it to land whenever makes sense.

@stephendonner
Copy link

Verified PASSED using

Brave 1.49.97 Chromium: 110.0.5481.77 (Official Build) beta (x86_64)
Revision 65ed616c6e8ee3fe0ad64fe83796c020644d42af-refs/branch-heads/5481@{#839}
OS macOS Version 11.7.3 (Build 20G1116)

Steps:

  1. installed 1.49.97
  2. launched Brave
  3. opened a new-tab page
  4. scrolled down
  5. clicked on Show Brave News
  6. followed a few sources
  7. clicked on View All beside Suggestions

Confirmed we now cap the Suggestions list at 15 items, where we have over 3 pages worth, in 1.49.15

1.49.97 1.49.15 1.49.15, page 2 1.49.15, page 3
Screen Shot 2023-02-14 at 10 02 47 PM Screen Shot 2023-02-14 at 10 21 05 PM Screen Shot 2023-02-14 at 10 21 12 PM Screen Shot 2023-02-14 at 10 22 03 PM

@Uni-verse
Copy link
Contributor

Verified on Samsung GS 21 using version:

Brave	1.49.117 Chromium: 111.0.5563.50 (Official Build) (64-bit) 
Revision	39f3dfc5023fe60997adc4f6cf5439cfa3e6968a-refs/branch-heads/5563@{#903}
OS	Android 13; Build/TP1A.220624.014

Using Test Plan in brave/brave-core#16790 (comment)

Precondition: Brave News V2 enabled

  • Ensured following some sources will create a suggestions list
  • Ensured that the number of items in the suggestions is capped at 15
Example Example
screenshot-1677787301464 screenshot-1677789749826

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
feature/brave-news formerly brave-today OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass-macOS QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants