-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Support :has
pseudoclass in cosmetic filters
#27874
Comments
Verification
|
Verified
|
Brave | 1.49.90 Chromium: 110.0.5481.77 (Official Build) beta (x86_64) |
---|---|
Revision | 65ed616c6e8ee3fe0ad64fe83796c020644d42af-refs/branch-heads/5481@{#839} |
OS | macOS Version 11.7.3 (Build 20G1116) |
Followed the steps to reproduce and test plan from brave/brave-core#16716 (comment)
Confirmed codecademy
and tutorialspoint
(and others) so-called partnershop
ads are removed
standard blocking |
aggressive blocking (no codecademy , no tutorialspoint ) |
---|---|
---- | ---- |
![]() |
![]() |
![]() |
![]() |
Verified with
Verified the test plan from brave/brave-core#16716 (comment). Reproduced the issue using 1.48.171, green "Partnership" ads visible under both options:
Verified using 1.49.x, green "Partnership" ads only visible under Standard, not Aggressive:
|
so this fix will finally enable in brave android the blocking of "promoted" ads on reddit and 9gag? |
@424344 that should be the case! |
thanks! |
Verification PASSED on Verified the test plan from brave/brave-core#16716 (comment). Reproduced the issue using 1.48.171, green "Partnership" ads visible under both options:
Verified using 1.49.x, green "Partnership" ads only visible under Standard, not Aggressive:
|
The
:has
pseudoclass is now a stable Chromium feature. It's used by a fairly large number of cosmetic filters, so it'd be good to support it natively (as if it weren't a procedural filter) before full procedural filtering support is available.The text was updated successfully, but these errors were encountered: