Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Support :has pseudoclass in cosmetic filters #27874

Closed
antonok-edm opened this issue Jan 18, 2023 · 7 comments · Fixed by brave/brave-core#16716
Closed

Support :has pseudoclass in cosmetic filters #27874

antonok-edm opened this issue Jan 18, 2023 · 7 comments · Fixed by brave/brave-core#16716

Comments

@antonok-edm
Copy link
Collaborator

The :has pseudoclass is now a stable Chromium feature. It's used by a fairly large number of cosmetic filters, so it'd be good to support it natively (as if it weren't a procedural filter) before full procedural filtering support is available.

@MadhaviSeelam
Copy link

MadhaviSeelam commented Feb 8, 2023

Verification PASSED using

Brave | 1.49.89 Chromium: 110.0.5481.77 (Official Build) beta (64-bit)
-- | --
Revision | 65ed616c6e8ee3fe0ad64fe83796c020644d42af-refs/branch-heads/5481@{#839}
OS | Windows 11 Version 21H2 (Build 22000.1455)
  1. Install 1.49.89
  2. launch Brave
  3. Visit https://metager.org/meta/meta.ger3?eingabe=software%20testing&focus=web&mgv=31901855042b9c5b2820d821141a7be9
  4. verified green partnershop labels displayed to the right of the URL in the results list for default Block trackers & ads setting
    • codecademy.com/.../blog/what-is-software-testing
    • tutorialspoint.com/software_testing/index.htm
    • edureka.co/blog/what-is-software-testing
  5. change the setting to Aggressively block trackers & ads in the shields panel
  6. confirmed the entries previously labeled with green partnership labels (step 6) are no longer visible.
standard blocking aggressive blocking
---- ----
image image
image image

@stephendonner
Copy link

Verified PASSED using

Brave 1.49.90 Chromium: 110.0.5481.77 (Official Build) beta (x86_64)
Revision 65ed616c6e8ee3fe0ad64fe83796c020644d42af-refs/branch-heads/5481@{#839}
OS macOS Version 11.7.3 (Build 20G1116)

Followed the steps to reproduce and test plan from brave/brave-core#16716 (comment)

Confirmed codecademy and tutorialspoint (and others) so-called partnershop ads are removed

standard blocking aggressive blocking (no codecademy, no tutorialspoint)
---- ----
Screen Shot 2023-02-08 at 4 08 44 PM Screen Shot 2023-02-08 at 4 16 58 PM
Screen Shot 2023-02-08 at 4 10 19 PM Screen Shot 2023-02-08 at 4 20 55 PM

@LaurenWags LaurenWags added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Feb 28, 2023
@LaurenWags
Copy link
Member

LaurenWags commented Feb 28, 2023

Verified with

Brave	1.49.114 Chromium: 110.0.5481.177 (Official Build) beta (64-bit) 
Revision	f34f7ab2d4ca4ad498ef42aeba4f4eb2c1392d63-refs/branch-heads/5481@{#1239}
OS	Linux

Verified the test plan from brave/brave-core#16716 (comment).

Reproduced the issue using 1.48.171, green "Partnership" ads visible under both options:

Standard Aggressive
1 48 x a 1 48 x b

Verified using 1.49.x, green "Partnership" ads only visible under Standard, not Aggressive:

Standard Aggressive
1 49 x a 1 49 x b

@LaurenWags LaurenWags added QA Pass-Linux and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Feb 28, 2023
@lazymonkey2
Copy link

so this fix will finally enable in brave android the blocking of "promoted" ads on reddit and 9gag?

@antonok-edm
Copy link
Collaborator Author

@424344 that should be the case!

@lazymonkey2
Copy link

thanks!

@GeetaSarvadnya
Copy link

Verification PASSED on Samsung Galaxy version 12 running Bravemonoarm64.apk_1.49.118

Verified the test plan from brave/brave-core#16716 (comment).

Reproduced the issue using 1.48.171, green "Partnership" ads visible under both options:

Standard Aggressive
Screenshot_20230307-181538_Brave Screenshot_20230307-181516_Brave

Verified using 1.49.x, green "Partnership" ads only visible under Standard, not Aggressive:

Standard Aggressive Aggressive Aggressive
Screenshot_20230307-181704_Brave Screenshot_20230307-181746_Brave Screenshot_20230307-181752_Brave Screenshot_20230307-181758_Brave

# for free to join this conversation on GitHub. Already have an account? # to comment