Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

When opening a URL from another application in Brave (MacOS) and Brave has no open windows, the window is not made active. #28406

Closed
mclow opened this issue Feb 9, 2023 · 4 comments

Comments

@mclow
Copy link

mclow commented Feb 9, 2023

Description

When I click on a link in another application, Brave opens a window and displays the web page. Good.
However, if Brave has no other windows open, the Brave window is not made active - even though Brave becomes the active application.

If Brave already has a window open, the contents of the link are displayed in a new tab, and the window becomes active.

Steps to Reproduce

  1. Have Brave running, but no windows open.
  2. In a terminal app, run 'open -a Brave\ Browser https://www.apple.com'
  3. Try to close the Brave window that appears with cmd-W. Brave just beeps. Note that the "traffic lights" in the upper right corner (close/minimize/zoom) are not colored; the window is not active.
  4. Click in the window - it becomes active. See the traffic lights become colored.
  5. Hit cmd-W. The window closes.

Actual result:

The window does not become active - i.e, keystrokes are not directed to the window.

Expected result:

The window should become active.

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 1.48.158 Chromium: 110.0.5481.77 (Official Build) (x86_64)
Revision 65ed616c6e8ee3fe0ad64fe83796c020644d42af-refs/branch-heads/5481@{#839}
OS macOS Version 12.6.3 (Build 21G419)
JavaScript V8 11.0.226.13
User Agent Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/110.0.0.0 Safari/537.36
Command Line /Applications/Brave Browser.app/Contents/MacOS/Brave Browser --disable-domain-reliability --enable-dom-distiller --origin-trial-public-key=bYUKPJoPnCxeNvu72j4EmPuK7tr1PAC7SHh8ld9Mw3E=,fMS4mpO6buLQ/QMd+zJmxzty/VQ6B1EUZqoCU04zoRU= --sync-url=https://sync-v2.brave.com/v2 --lso-url=https://no-thanks.invalid --variations-server-url=https://variations.brave.com/seed --variations-insecure-server-url=https://variations.brave.com/seed --flag-switches-begin --flag-switches-end --component-updater=url-source=https://go-updater.brave.com/extensions
Executable Path /Applications/Brave Browser.app/Contents/MacOS/Brave Browser
Profile Path /Users/marshall/Library/Application Support/BraveSoftware/Brave-Browser/Default
Linker lld
Active Variations AdRewardsStudy:NextPaymentDay
AdvertiserSplitTestStudy:GroupA
AllowCertainClientHintsStudy:Disabled
BraveAdblockCookieListOptInReleaseStudy:Enabled
BraveAds.AdServingStudy:DefaultAdNotificationsPerHour=10/MaximumAdNotificationsPerDay=100/MaximumInlineContentAdsPerHour=6/MaximumInlineContentAdsPerDay=20/AdServingVersion=1
BraveAds.FrequencyCappingStudy:ExcludeAdIfWithinTimeWindow=0h
BraveAutoTranslateStudy:AutoTranslateDisabled
BraveDebounceStudy:Enabled
BraveRewardsWebUiPanelStudy:Enabled
BraveScreenFingerprintingBlockerStudy:Default
ConversionsStudy:NewDefaultPattern
Default1pBlockingStudy:Disabled
DisableReduceLanguage:Enabled
EphemeralStorageStudy:Enabled
FirstPartyEphemeralDomainBlockStudy:Enabled
ForceDisableBlinkFeatures:Enabled
MacCoreLocationBackendStudy:Enabled
PartitionBlinkMemoryCacheStudy:Enabled
PartitionConnectionsByNetworkIsolationKeyStudy:Enabled
PermissionLifetimeReleaseStudy:Enabled
SpeedreaderReleaseStudy:Enabled
UserActivityStudy:Triggers

Version/Channel Information:

As far as I know, I am running the current release.

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@mclow
Copy link
Author

mclow commented Feb 9, 2023

Upper LEFT corner, not upper right.

@mclow
Copy link
Author

mclow commented Feb 10, 2023

Is the issue reproducible on the latest version of Chrome?

The issue IS present in Version 110.0.5481.77 (Official Build) (x86_64)

@mclow
Copy link
Author

mclow commented Feb 10, 2023

@mclow
Copy link
Author

mclow commented Mar 5, 2023

This is fixed in Chromium 110.0.5481.177, and so, fixed in Brave v1.48.171. I have confirmed the expected behavior.

@mclow mclow closed this as completed Mar 5, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

1 participant