Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Tab separator is too thick #3081

Closed
petemill opened this issue Jan 24, 2019 · 2 comments · Fixed by brave/brave-core#1449
Closed

Tab separator is too thick #3081

petemill opened this issue Jan 24, 2019 · 2 comments · Fixed by brave/brave-core#1449
Assignees
Labels

Comments

@petemill
Copy link
Member

Consensus from @brave/design and some user feedback is that the 2dp border between tabs is too priminent. Althought that prominence is a feature to aid cognitive understanding of where the different tabs begin and end, it can also add to cognitive load.

@petemill petemill added feature/tabs-bar design A design change, especially one which needs input from the design team labels Jan 24, 2019
@petemill petemill self-assigned this Jan 24, 2019
@petemill petemill added this to the 1.x Backlog milestone Jan 24, 2019
@petemill petemill modified the milestones: 1.x Backlog, 0.62.x - Nightly Jan 25, 2019
@bbondy bbondy modified the milestones: 0.62.x - Nightly, 0.61.x - Dev Feb 13, 2019
@bbondy
Copy link
Member

bbondy commented Feb 13, 2019

Bumping this to 0.61.x since it'll be included as part of a rebase conflict that will be included with the 73.0.3683.27 upgrade.

@btlechowski
Copy link

btlechowski commented Feb 26, 2019

Verification passed on

Brave 0.61.37 Chromium: 73.0.3683.39 (Official Build) beta (64-bit)
Revision cc53b0e12fcaf42e4bab8d6c23bd4fb7aae99f6c-refs/branch-heads/3683@{#413}
OS Windows 7 Service Pack 1 Build 7601.24312

Used test plan from brave/brave-core#1449. The tab separator has 1 px.

top: 0.61.37
bottom: 0.60.45
image

Verification PASSED on macOS 10.14.3 x64 using the following build:

Brave 0.61.45 Chromium: 73.0.3683.39 (Official Build) beta(64-bit)
Revision cc53b0e12fcaf42e4bab8d6c23bd4fb7aae99f6c-refs/branch-heads/3683@{#413}
OS Mac OS X

screen shot 2019-03-05 at 1 16 22 am

Verification passed on

Brave 0.61.46 Chromium: 73.0.3683.39 (Official Build) beta (64-bit)
Revision cc53b0e12fcaf42e4bab8d6c23bd4fb7aae99f6c-refs/branch-heads/3683@{#413}
OS Linux

image

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants