Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

secp256k1_context instance should be global #31563

Closed
supermassive opened this issue Jul 11, 2023 · 2 comments · Fixed by brave/brave-core#19229
Closed

secp256k1_context instance should be global #31563

supermassive opened this issue Jul 11, 2023 · 2 comments · Fixed by brave/brave-core#19229
Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.58.x - Release

Comments

@supermassive
Copy link

supermassive commented Jul 11, 2023 •
edited
Loading

More in PR https://github.com/brave/brave-core/pull/19229/files
@supermassive supermassive added QA/Yes release-notes/exclude feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop labels Jul 11, 2023
@supermassive supermassive mentioned this issue Jul 11, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.58.x - Nightly milestone Jul 13, 2023
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.58.105 Chromium: 116.0.5845.114 (Official Build) beta (64-bit)
Revision 5a895596bcd7fcd930dab0714ea5cfa86c5aa0a7
OS Windows 11 Version 22H2 (Build 22621.2215)
  • Verified basic wallet features work as expected.

@supermassive supermassive mentioned this issue Sep 4, 2023
Open
@srirambv
Copy link
Contributor

Verification passed on Oppo Reno 5 with Android 13 running 1.58.117 x64 build

  • Verified basic wallet features work as expected

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.58.x - Release
Development

Successfully merging a pull request may close this issue.

Global secp256k1_context brave/brave-core
3 participants
@supermassive @srirambv @brave-builds