Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Wallet: Make NFTs under NFTs tab to fallback to token.logo if failed to fetch NFT metadata #36708

Closed
nuo-xu opened this issue Mar 11, 2024 · 0 comments · Fixed by brave/brave-core#27129
Closed

Wallet: Make NFTs under NFTs tab to fallback to token.logo if failed to fetch NFT metadata #36708

nuo-xu opened this issue Mar 11, 2024 · 0 comments · Fixed by brave/brave-core#27129
Assignees
@nuo-xu
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/iOS Fixes related to iOS browser functionality priority/P4 Planned work. We expect to get to it "soon". QA/No release-notes/exclude
Milestone
1.75.x - Release

Comments

@nuo-xu
Copy link

nuo-xu commented Mar 11, 2024

fetch NFT metadata fails intermittently. we need to fallback to token.logo like we do in token list screen.
@nuo-xu nuo-xu added feature/web3/wallet Integrating Ethereum+ wallet support OS/iOS Fixes related to iOS browser functionality labels Mar 11, 2024
@nuo-xu nuo-xu added this to Web3 Mar 11, 2024
@nuo-xu nuo-xu mentioned this issue Mar 12, 2024
Merged
24 tasks
@StephenHeaps StephenHeaps moved this to Backlog in Web3 Mar 15, 2024
@StephenHeaps StephenHeaps added the priority/P4 Planned work. We expect to get to it "soon". label Mar 15, 2024
@nuo-xu nuo-xu moved this from Backlog to In Progress in Web3 Jan 6, 2025
@nuo-xu nuo-xu mentioned this issue Jan 6, 2025
Merged
24 tasks
@github-project-automation github-project-automation bot moved this from In Progress to Done in Web3 Jan 6, 2025
@brave-builds brave-builds added this to the 1.75.x - Nightly milestone Jan 6, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@nuo-xu nuo-xu

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/iOS Fixes related to iOS browser functionality priority/P4 Planned work. We expect to get to it "soon". QA/No release-notes/exclude
Projects
Web3
Archived in project
Milestone
1.75.x - Release
Development

Successfully merging a pull request may close this issue.

fix(wallet): fallback to token.logo as the NFT image url brave/brave-core
3 participants
@nuo-xu @StephenHeaps @brave-builds