Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Initial Bitcoin Setup for iOS #36807

Closed
StephenHeaps opened this issue Mar 14, 2024 · 0 comments · Fixed by brave/brave-core#22632
Closed

Initial Bitcoin Setup for iOS #36807

StephenHeaps opened this issue Mar 14, 2024 · 0 comments · Fixed by brave/brave-core#22632
Assignees
@StephenHeaps
Labels
feature/web3/wallet/bitcoin feature/web3/wallet Integrating Ethereum+ wallet support OS/iOS Fixes related to iOS browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude
Milestone
1.66.x - Release

Comments

@StephenHeaps
Copy link

StephenHeaps commented Mar 14, 2024 •
edited
Loading

Description:

This issue is intended to start Bitcoin work for iOS, allowing different pieces to be worked on at once without conflicting with one another.

We should also setup a Bitcoin Wallet Service Factory to provide the BitcoinWalletService to TxService on iOS:
https://github.com/brave/brave-core/tree/master/ios/browser/brave_wallet

And update the TxService constructor to include BitcoinWalletService:
https://github.com/brave/brave-core/blob/master/ios/browser/brave_wallet/tx_service_factory.cc#L85
@StephenHeaps StephenHeaps added QA/No release-notes/exclude feature/web3/wallet Integrating Ethereum+ wallet support OS/iOS Fixes related to iOS browser functionality feature/web3/wallet/bitcoin labels Mar 14, 2024
@StephenHeaps StephenHeaps self-assigned this Mar 14, 2024
@StephenHeaps StephenHeaps mentioned this issue Mar 14, 2024
Open
@StephenHeaps StephenHeaps moved this to In Progress in Web3 Mar 15, 2024
@StephenHeaps StephenHeaps added the priority/P3 The next thing for us to work on. It'll ride the trains. label Mar 15, 2024
@StephenHeaps StephenHeaps mentioned this issue Mar 15, 2024
Merged
24 tasks
@github-project-automation github-project-automation bot moved this from In Progress to Done in Web3 Mar 18, 2024
@brave-builds brave-builds added this to the 1.66.x - Nightly milestone Mar 18, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@StephenHeaps StephenHeaps

Labels
feature/web3/wallet/bitcoin feature/web3/wallet Integrating Ethereum+ wallet support OS/iOS Fixes related to iOS browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude
Projects
Web3
Archived in project
Milestone
1.66.x - Release
Development

Successfully merging a pull request may close this issue.

fix(wallet): Setup core services for Bitcoin on iOS brave/brave-core
2 participants
@StephenHeaps @brave-builds