Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Support Creating Bitcoin Accounts on iOS #36811

Closed
StephenHeaps opened this issue Mar 14, 2024 · 1 comment · Fixed by brave/brave-core#22737
Closed

Support Creating Bitcoin Accounts on iOS #36811

StephenHeaps opened this issue Mar 14, 2024 · 1 comment · Fixed by brave/brave-core#22737
Assignees
@nuo-xu
Labels
feature/web3/wallet/bitcoin feature/web3/wallet Integrating Ethereum+ wallet support OS/iOS Fixes related to iOS browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - iPhone X QA/Yes release-notes/exclude
Milestone
1.66.x - Release

Comments

@StephenHeaps
Copy link

StephenHeaps commented Mar 14, 2024 •
edited
Loading

Description:

Add support for creating a Bitcoin account in accounts tab. Note that Bitcoin accounts do not have an address for display, might require fix-up on Account tab UI. Hiding NFTs/Dapp Connections rows in account details, disabling export account, etc may suffice for this issue.

We should use the BraveCore FeatureList support to enabled Bitcoin when the BraveCore Bitcoin feature flag is enabled.

This brave core feature flag can be checked on iOS side via:

BraveCore.FeatureList.kBraveWalletBitcoinFeature.enabled
@StephenHeaps StephenHeaps added feature/web3/wallet Integrating Ethereum+ wallet support OS/iOS Fixes related to iOS browser functionality feature/web3/wallet/bitcoin labels Mar 14, 2024
@StephenHeaps StephenHeaps changed the title Support Creating Bitcoin Accounts Support Creating Bitcoin Accounts on iOS Mar 14, 2024
@StephenHeaps StephenHeaps mentioned this issue Mar 14, 2024
Open
@StephenHeaps StephenHeaps moved this to Backlog in Web3 Mar 15, 2024
@StephenHeaps StephenHeaps added the priority/P3 The next thing for us to work on. It'll ride the trains. label Mar 15, 2024
This was referenced Mar 20, 2024
Closed
Merged
@github-project-automation github-project-automation bot moved this from Backlog to Done in Web3 Apr 2, 2024
@mihaiplesa mihaiplesa added this to the 1.66.x - Nightly milestone Apr 2, 2024
@nuo-xu nuo-xu added the QA/Yes label Apr 5, 2024
@srirambv
Copy link
Contributor

Verification passed on iPhone 13 with iOS 17.5 running 1.66 (105) Beta build

  • Verified steps from brave/brave-core#22737
  • Verified Bitcoin on Mainnet is displayed on Portfolio on a clean wallet creation
  • Verified Bitcoin accounts can be created for both Mainnet and Testnet
  • Verified on clean wallet select Bitcoin from portfolio and selecting Deposit/Send shows account creation prompt
  • Verified able to edit Bitcoin account name on both Mainnet and Testnet
  • Encountered #36966 & #36968
36811.MP4

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@nuo-xu nuo-xu

Labels
feature/web3/wallet/bitcoin feature/web3/wallet Integrating Ethereum+ wallet support OS/iOS Fixes related to iOS browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - iPhone X QA/Yes release-notes/exclude
Projects
Web3
Archived in project
Milestone
1.66.x - Release
Development

Successfully merging a pull request may close this issue.

[iOS] Bitcoin account creation brave/brave-core
4 participants
@mihaiplesa @nuo-xu @StephenHeaps @srirambv