Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Leo - Add "You / Leo" name indicator besides avatar on the top header of every prompt/answer #37793

Closed
aguscruiz opened this issue Apr 23, 2024 · 2 comments · Fixed by brave/brave-core#24471
Closed

Leo - Add "You / Leo" name indicator besides avatar on the top header of every prompt/answer #37793

aguscruiz opened this issue Apr 23, 2024 · 2 comments · Fixed by brave/brave-core#24471
Assignees
@mattmcalister @Brandon-T
Labels
browser-ai design A design change, especially one which needs input from the design team OS/iOS Fixes related to iOS browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - iPad QA/Yes release-notes/include
Milestone
1.68.x - Release

Comments

@aguscruiz
Copy link

aguscruiz commented Apr 23, 2024 •
edited
Loading

Description:

  • Addding the name of the sender at the right side of the avatar.

Design example:
https://www.figma.com/file/m0Gdbf0wtqyfEFGm32VLLc/Leo?type=design&node-id=3125%3A40451&mode=design&t=SWVdp58qkdjl54Jg-1

Design system for button states:
https://www.figma.com/file/MNwi0uwXNhkAbPiJ86G4vm/%E2%9C%A8-Leo?type=design&node-id=1506%3A8040&mode=design&t=MzAuxvpPR619wmZL-1

Expected result:

image
@aguscruiz aguscruiz added OS/iOS Fixes related to iOS browser functionality browser-ai labels Apr 23, 2024
@aguscruiz aguscruiz added the design A design change, especially one which needs input from the design team label Jun 25, 2024
@aguscruiz aguscruiz changed the title Leo - Add "You / Leo" name indicator besides avatar and most popular actions on the top header of every prompt/answer Leo - Add "You / Leo" name indicator besides avatar on the top header of every prompt/answer Jun 25, 2024
@mattmcalister mattmcalister added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jun 25, 2024
@Brandon-T Brandon-T mentioned this issue Jul 2, 2024
Merged
24 tasks
@kjozwiak kjozwiak mentioned this issue Jul 5, 2024
Merged
7 tasks
@brave-builds brave-builds added this to the 1.68.x - Beta milestone Jul 5, 2024
@kjozwiak
Copy link
Member

kjozwiak commented Jul 5, 2024

The above requires 1.68.112 or higher for 1.68.x verification 👍

@Uni-verse
Copy link
Contributor

Verified on iPad (7th Gen) running iPadOS 17.5.1 using version 1.68.117

  • Ensured that You is shown beside the users avatar for every prompt.
  • Ensured You is shown when summarizing, retrieving suggested questions and uncontext messages.
Example Example
IMG_1494 IMG_1495

@Uni-verse Uni-verse mentioned this issue Sep 11, 2024
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@mattmcalister mattmcalister

@Brandon-T Brandon-T

Labels
browser-ai design A design change, especially one which needs input from the design team OS/iOS Fixes related to iOS browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - iPad QA/Yes release-notes/include
Projects
None yet
Milestone
1.68.x - Release
Development

Successfully merging a pull request may close this issue.

[iOS] - Leo De#dates brave/brave-core
6 participants
@mattmcalister @Brandon-T @kjozwiak @aguscruiz @Uni-verse @brave-builds