Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Send BTC on iOS #37958

Closed
StephenHeaps opened this issue Apr 30, 2024 · 1 comment · Fixed by brave/brave-core#23476
Closed

Send BTC on iOS #37958

StephenHeaps opened this issue Apr 30, 2024 · 1 comment · Fixed by brave/brave-core#23476
Assignees
@StephenHeaps
Labels
feature/web3/wallet/bitcoin feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/iOS Fixes related to iOS browser functionality QA Pass - iPhone X QA/Yes release-notes/include
Milestone
1.68.x - Release

Comments

@StephenHeaps
Copy link

Description:

We need to support ability to send BTC in iOS send token.

  • Display Bitcoin accounts w/ available balance in Select Token to Send modal
  • Display Bitcoin available balance in Send
  • Validate send to address for bitcoin
  • Show a warning with confirmation before allowing send:

Brave Wallet does not currently support Bitcoin NFTs (ordinals). Sending BTC from an address that has ordinals may result in its ordinals being transferred inadvertently.
@StephenHeaps StephenHeaps added QA/Yes feature/web3/wallet Integrating Ethereum+ wallet support OS/iOS Fixes related to iOS browser functionality front-end-change This task is a front end task and doesn't need any C++ changes feature/web3/wallet/bitcoin labels Apr 30, 2024
@StephenHeaps StephenHeaps self-assigned this Apr 30, 2024
@StephenHeaps StephenHeaps mentioned this issue Apr 30, 2024
Open
@StephenHeaps StephenHeaps moved this to In Progress in Web3 Apr 30, 2024
@StephenHeaps StephenHeaps mentioned this issue Apr 30, 2024
Merged
24 tasks
@StephenHeaps StephenHeaps mentioned this issue May 7, 2024
Merged
24 tasks
@github-project-automation github-project-automation bot moved this from In Progress to Done in Web3 May 21, 2024
@brave-builds brave-builds added this to the 1.68.x - Nightly milestone May 21, 2024
@srirambv
Copy link
Contributor

Verification passed on iPhone 13 with iOS 18.0 Beta running 1.68 (117)

  • Verified steps from brave/brave-core#23476
  • Verified able to send BTC from one account to another
  • Verified incorrect address shows error message
  • Verified Send button is only enabled when the info switch is enabled
  • Verified receiving address shows message about balance update
  • Verified clicking on view details shows the balance and pending
image image image image image image image
image image image image image image

@Uni-verse Uni-verse mentioned this issue Sep 11, 2024
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@StephenHeaps StephenHeaps

Labels
feature/web3/wallet/bitcoin feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/iOS Fixes related to iOS browser functionality QA Pass - iPhone X QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.68.x - Release
Development

Successfully merging a pull request may close this issue.

feat(wallet): Send BTC on iOS brave/brave-core
3 participants
@StephenHeaps @srirambv @brave-builds