Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[iOS] Leo - Change eraser icon to a "new chat" icon #39818

Closed
aguscruiz opened this issue Jul 17, 2024 · 1 comment · Fixed by brave/brave-core#24837
Closed

[iOS] Leo - Change eraser icon to a "new chat" icon #39818

aguscruiz opened this issue Jul 17, 2024 · 1 comment · Fixed by brave/brave-core#24837
Assignees
Labels
browser-ai design A design change, especially one which needs input from the design team OS/iOS Fixes related to iOS browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - iPhone QA/Yes release-notes/include

Comments

@aguscruiz
Copy link

aguscruiz commented Jul 17, 2024

Description

With history coming, we'll need to change that perceived behavior. We're removing the eraser icon and replacing it with a new chat icon to indicate new chats.

Affects:

  • Header icon
  • Menu icon

Figma:
https://www.figma.com/design/m0Gdbf0wtqyfEFGm32VLLc/%F0%9F%94%84-Leo-%5BIN-PROGRESS%5D?node-id=4580-3756&t=TgZmFYdaof0pLf7a-1

@aguscruiz aguscruiz added design A design change, especially one which needs input from the design team OS/iOS Fixes related to iOS browser functionality browser-ai labels Jul 17, 2024
@aguscruiz aguscruiz changed the title Leo - Change eraser icon to a "plus" icon Leo - Change eraser icon to a "new chat" icon Jul 17, 2024
@mattmcalister mattmcalister added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include labels Jul 17, 2024
@mattmcalister mattmcalister moved this to Todo in Browser AI Jul 17, 2024
@mattmcalister mattmcalister moved this from Todo to Important / Polish in Browser AI Jul 17, 2024
@nullhook nullhook changed the title Leo - Change eraser icon to a "new chat" icon [iOS] Leo - Change eraser icon to a "new chat" icon Jul 22, 2024
@StephenHeaps StephenHeaps self-assigned this Jul 25, 2024
@github-project-automation github-project-automation bot moved this from Important / Polish to Done in Browser AI Jul 25, 2024
@brave-builds brave-builds added this to the 1.70.x - Nightly milestone Jul 25, 2024
@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Sep 20, 2024
@hffvld
Copy link
Contributor

hffvld commented Sep 20, 2024

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 / iOS 17.7
Brave build: 1.70 (117)
BraveCore: 1.70.117 (129.0.6668.59)

STEPS:

  1. Launch Brave
  2. Open Leo > Verify New Chat icon
  3. Tap Hamburger menu > Verify, that no New Chat name/icon is shown according to Leo - Remove "New chat" from 3dot menu #39932

ACTUAL RESULTS:

  • Verified that the Eraser icon was updated to the New Chat icon in the header menu.
  • Verified that tapping the New Chat icon clears the current conversation and starts a new chat.

1 2
1 2
1 2

@hffvld hffvld added QA Pass - iPhone and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Sep 20, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
browser-ai design A design change, especially one which needs input from the design team OS/iOS Fixes related to iOS browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - iPhone QA/Yes release-notes/include
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants