Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[Brave News]: Fix default slot content in ButtonMenu on ArticleCards #40621

Closed
fallaciousreasoning opened this issue Aug 22, 2024 · 2 comments
Closed

[Brave News]: Fix default slot content in ButtonMenu on ArticleCards #40621

fallaciousreasoning opened this issue Aug 22, 2024 · 2 comments
Assignees
@fallaciousreasoning
Labels
feature/brave-news formerly brave-today OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.69.x - Release #2

Comments

@fallaciousreasoning
Copy link

fallaciousreasoning commented Aug 22, 2024 •
edited by kjozwiak
Loading

This was fixed in Nala - unfortunately it landed in brave-core after a big tokens update, so we're going to create a 1.69.x branch in Nala and cherry-pick the fix.

Steps to repro:

  1. Open Brave News in 1.69.x
  2. Scroll down
  3. Note that the articles have the "Click Me" text in the corner, rather than the 3 dot menu

Example of the issue occurring for @brave/qa-team:

image
@fallaciousreasoning fallaciousreasoning added the feature/brave-news formerly brave-today label Aug 22, 2024
@fallaciousreasoning fallaciousreasoning self-assigned this Aug 22, 2024
@fallaciousreasoning fallaciousreasoning mentioned this issue Aug 22, 2024
Merged
24 tasks
@kjozwiak kjozwiak added this to the 1.69.x - Release #2 milestone Aug 26, 2024
@kjozwiak
Copy link
Member

The above requires 1.69.155 or higher for 1.69.x verification 👍

@GeetaSarvadnya GeetaSarvadnya added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Aug 26, 2024
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Aug 26, 2024 •
edited
Loading

Verification PASSED on

Brave | 1.69.155 Chromium: 128.0.6613.85 (Official Build) (64-bit)
-- | --
Revision | 83b4eeea6ba0d846b2c8a71f75036496b3056d36
OS | Windows 10 Version 22H2 (Build 19045.4780)

Confirmed that the the 3 dot menu is shown on the corner for the brave news feeds.
image

@GeetaSarvadnya GeetaSarvadnya added QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Aug 26, 2024
@LaurenWags LaurenWags mentioned this issue Aug 29, 2024
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@fallaciousreasoning fallaciousreasoning

Labels
feature/brave-news formerly brave-today OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
1.69.x - Release #2
Development

No branches or pull requests
3 participants
@kjozwiak @fallaciousreasoning @GeetaSarvadnya