Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add keyboard shortcut for exporting all bookmarks #41412

Closed
hamirmahal opened this issue Oct 4, 2024 · 8 comments · Fixed by brave/brave-core#25827
Closed

Add keyboard shortcut for exporting all bookmarks #41412

hamirmahal opened this issue Oct 4, 2024 · 8 comments · Fixed by brave/brave-core#25827
Assignees

Comments

@hamirmahal
Copy link

hamirmahal commented Oct 4, 2024

Test plan

  1. Have some bookmarks already loaded (bookmark a few sites)
  2. Visit brave://settings/system/shortcuts
  3. Find the shortcut for Export all bookmarks (you can search if it's easier)
  4. Bind this to Ctrl + Shift + E
  5. Close the tab
  6. Try out the shortcut (Ctrl + Shift + E). Doesn't matter what tab you have open,
  7. It should pop up a modal with where to save
  8. Verify the exported file looks good and that it saved to where you picked it

Description

If you wanted to add a command for exporting bookmarks and/or clearing downloads we'd definitely accept a PR

Originally posted by @fallaciousreasoning in #39489 (comment)

@jonathansampson
Copy link
Contributor

jonathansampson commented Oct 5, 2024

This is looking good, but unfortunately doesn't build in its current state due to no ExportBookmarks member on the chrome namespace.

@bsclifton
Copy link
Member

@hamirmahal I added a test plan to your top post - let me know what you think!

@hamirmahal
Copy link
Author

It looks reasonable!

I just downloaded brave-browser-nightly and tried out the feature.

@hamirmahal
Copy link
Author

Screen Recording of Feature

This is on brave-browser-nightly.

Screencast.from.11-11-2024.04.19.22.PM.webm

@fallaciousreasoning
Copy link

Looks great!

@rebron
Copy link
Collaborator

rebron commented Nov 13, 2024

Image

Beautiful. Works great. Thanks @hamirmahal

@hamirmahal
Copy link
Author

You're welcome, @rebron.

@rebron rebron added this to the 1.75.x - Nightly milestone Dec 3, 2024
@rebron rebron changed the title add keyboard shortcut for exporting all bookmarks Add keyboard shortcut for exporting all bookmarks Dec 10, 2024
@MadhaviSeelam
Copy link

MadhaviSeelam commented Jan 6, 2025

Verification PASSED using

Brave | 1.75.145 Chromium: 132.0.6834.57 (Official Build) nightly (64-bit)
-- | --
Revision | 4ecdecd1626892f9f317e9d8154c50cf8459d3bf
OS | Windows 11 Version 24H2 (Build 26100.2605)
  1. Installed 1.75.145
  2. launched Brave
  3. added few bookmarks
  4. opened brave://settings/system/shortcuts in a new tab
  5. search by export
  6. confirmed Export all bookmarks shortcut entry available
  7. clicked Add
  8. added shortcut (Ctrl + Shift + E) and clicked Save
  9. opened a new tab
  10. entered the shortcut ((Ctrl + Shift + E)) and saved bookmarks file
  11. confirmed the Bookmarks file is saved as expected via brave://bookmarks
2025-01-06_10h24_41.mp4

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

6 participants