Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add ability to search local items saved in Playlist #42437

Closed
kylehickinson opened this issue Nov 21, 2024 · 1 comment · Fixed by brave/brave-core#26933
Closed

Add ability to search local items saved in Playlist #42437

kylehickinson opened this issue Nov 21, 2024 · 1 comment · Fixed by brave/brave-core#26933
Assignees
Labels
features/playlist OS/iOS Fixes related to iOS browser functionality priority/P4 Planned work. We expect to get to it "soon". QA Pass - iPhone QA/Yes release-notes/include

Comments

@kylehickinson
Copy link
Collaborator

Some user feedback has come back asking to search videos they've saved in Playlist, we have some ongoing design for this in Figma: https://www.figma.com/design/gafcumKE9O6T4A844I8SvL/iOS-Playlist?node-id=5782-136088

This would be part 1 which adds just the ability to search for videos you have saved already

@kylehickinson kylehickinson added features/playlist OS/iOS Fixes related to iOS browser functionality QA/Yes labels Nov 21, 2024
@kylehickinson kylehickinson self-assigned this Nov 21, 2024
@jamesmudgett jamesmudgett added the priority/P4 Planned work. We expect to get to it "soon". label Nov 22, 2024
@brave-builds brave-builds added this to the 1.75.x - Nightly milestone Dec 12, 2024
@Uni-verse Uni-verse added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Dec 17, 2024
@Uni-verse
Copy link
Contributor

Verified on iPhone 12 running iOS 18.2 using version 1.75 (102)

Verified the following acceptance criteria using test plan in brave/brave-core#26933 (comment)

  • Verified tapping on the spyglass will open search field
  • Verified you can search for items in multiple folders by name
  • Verified items shown show the correct download states
  • Verified long pressing on items shows the same context menu and that those buttons work correctly
  • Verified that tapping on an item starts playing that item the same way as if tapped on the main sidebar/drawer list
example example example example

@Uni-verse Uni-verse added QA Pass - iPhone and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Dec 17, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
features/playlist OS/iOS Fixes related to iOS browser functionality priority/P4 Planned work. We expect to get to it "soon". QA Pass - iPhone QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants