Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Replace "earnings so far" indicator in Rewards 2.5 UI #42475

Closed
4 tasks
Miyayes opened this issue Nov 23, 2024 · 6 comments · Fixed by brave/brave-core#26751
Closed
4 tasks

Replace "earnings so far" indicator in Rewards 2.5 UI #42475

Miyayes opened this issue Nov 23, 2024 · 6 comments · Fixed by brave/brave-core#26751
Assignees
@zenparsing
Labels
feature/rewards OS/Desktop priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include rewards-2.0
Milestone
1.73.x - Release #3

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Nov 23, 2024 •
edited
Loading

  • Rewards panel: replace with Ads seen this month
  • Rewards page: remove relevant line item and from page card
  • NTP Rewards card
  • Check for any other appearances
@Miyayes Miyayes added feature/rewards priority/P1 A very extremely bad problem. We might push a hotfix for it. rewards-2.0 labels Nov 23, 2024
@github-project-automation github-project-automation bot moved this to New Issues in Brave Rewards Nov 23, 2024
@Miyayes Miyayes mentioned this issue Nov 23, 2024
Closed
3 tasks
@Miyayes Miyayes changed the title Replace "earnings so far" language in Rewards 2.5 UI Replace "earnings so far" indicator in Rewards 2.5 UI Nov 23, 2024
@LaurenWags
Copy link
Member

Two things:

  1. The NTP widget needs to be handled also as this info is also displayed there (didn't see that mentioned in the description)
  2. On brave://rewards this info is displayed in two places: one is in the "Manage Brave Ads" section (mentioned in the description) as well as on the left where the custodial wallet info is for connected accounts (not explicitly called out in the description). Not sure if this will be handled by the removal of this info from the panel or not, so wanted to be sure it was called out specifically.
Widget brave://rewards
Image Image

This was referenced Nov 25, 2024
Closed
Merged
@github-project-automation github-project-automation bot moved this from New Issues to Done in Brave Rewards Nov 27, 2024
@brave-builds brave-builds added this to the 1.75.x - Nightly milestone Nov 27, 2024
This was referenced Nov 27, 2024
Merged
Merged
@kjozwiak
Copy link
Member

kjozwiak commented Dec 2, 2024

@LaurenWags added the QA/Test-All-Platforms label for the above but feel free to remove if you think only checking Win is good enough. Should at least spot check macOS & Linux as well.

@kjozwiak
Copy link
Member

kjozwiak commented Dec 2, 2024

The above requires 1.73.96 or higher for 1.73.x verification 👍

@LaurenWags
Copy link
Member

LaurenWags commented Dec 3, 2024 •
edited
Loading

Verified with

Brave | 1.73.96 Chromium: 131.0.6778.85 (Official Build) (x86_64)
-- | --
Revision | 6f21d9296a589898eb10fe739a33b830de6c9328
OS | macOS Version 14.7.1 (Build 23H222)

Verified test plan from brave/brave-core#26751 (comment).

Clean profile (Gemini) - PASSED
  1. Installed 1.73.96.
  2. Launched Brave, close/relaunch to pull griffin
  3. Joined rewards (staging env)
  4. No "Ads seen this month" UI is shown in unconnected state
Example Example Example
Image Image Image
  1. Connected to a custodian

Confirmed:

  • "Ads seen this month" is shown on the panel for both "Contribution" and "Summary" views
  • "Ads seen this month" is shown on the NTP widget
  • "Ads seen this month" is not shown on the wallet section/card of brave://rewards
  • "Total ads received this month" is still shown under "Manage Brave Ads" panel of brave://rewards
  • estimated earnings UI ("Earnings so far"/"Earnings so far this month") is not displayed on the panel, NTP widget, or brave://rewards (wallet section/card or under "Manage Brave Ads")
Panel Panel NTP Widget brave://rewards
Image Image Image Image

Confirmed that where the "Ads seen this month" UI is shown, it updates when a new ad is viewed:

Before After
Image Image
Image Image
Image Image
Image Image

Confirmed that when the month changes (updated system date to Jan 1), "Ads seen this month" resets as expected:

Panel Panel NTP Widget brave://rewards
Image Image Image Image
Upgrade profile (Uphold) - PASSED

Set up a profile using 1.73.91 which was connected to Uphold staging env. Viewed ads, etc prior to updating to 1.73.96. After updating, confirmed:

  • "Ads seen this month" is shown on the panel for both "Contribution" and "Summary" views
  • "Ads seen this month" is shown on the NTP widget
  • "Ads seen this month" is not shown on the wallet section/card of brave://rewards
  • "Total ads received this month" is still shown under "Manage Brave Ads" panel of brave://rewards
  • estimated earnings UI ("Earnings so far"/"Earnings so far this month") is not displayed on the panel, NTP widget, or brave://rewards (wallet section/card or under "Manage Brave Ads")
Panel Panel NTP Widget brave://rewards
Image Image Image Image

Confirmed that where the "Ads seen this month" UI is shown, it updates when a new ad is viewed:

Before After
Image Image
Image Image
Image Image
Image Image

@LaurenWags LaurenWags added QA/In-Progress Indicates that QA is currently in progress for that particular issue QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Dec 3, 2024
@btlechowski
Copy link

btlechowski commented Dec 3, 2024 •
edited
Loading

Verified with

Brave 1.73.96 Chromium: 131.0.6778.85 (Official Build) (64-bit)
Revision 6f21d9296a589898eb10fe739a33b830de6c9328
OS Linux

Verified test plan from brave/brave-core#26751 (comment).

Clean profile - PASSED
  1. Installed 1.73.96.
  2. Launched Brave, close/relaunch to pull griffin
  3. Joined rewards (staging env)
  4. No "Ads seen this month" UI is shown in unconnected state
Example Example Example
Image Image Image
  1. Connected to a custodian

Confirmed:

  • "Ads seen this month" is shown on the panel for both "Contribution" and "Summary" views
  • "Ads seen this month" is shown on the NTP widget
  • "Ads seen this month" is not shown on the wallet section/card of brave://rewards
  • "Total ads received this month" is still shown under "Manage Brave Ads" panel of brave://rewards
  • estimated earnings UI ("Earnings so far"/"Earnings so far this month") is not displayed on the panel, NTP widget, or brave://rewards (wallet section/card or under "Manage Brave Ads")
Panel NTP Widget brave://rewards
Image Image Image

Confirmed that where the "Ads seen this month" UI is shown, it updates when a new ad is viewed:

Image Image Image

Confirmed that when the month changes (updated system date to Jan 1), "Ads seen this month" resets as expected:

Panel NTP Widget brave://rewards
Image Image Image
Upgrade profile (Uphold) - PASSED

Set up a profile using 1.73.91

Image Image Image

After updating, confirmed:

  • "Ads seen this month" is shown on the panel for both "Contribution" and "Summary" views
  • "Ads seen this month" is shown on the NTP widget
  • "Ads seen this month" is not shown on the wallet section/card of brave://rewards
  • "Total ads received this month" is still shown under "Manage Brave Ads" panel of brave://rewards
  • estimated earnings UI ("Earnings so far"/"Earnings so far this month") is not displayed on the panel, NTP widget, or brave://rewards (wallet section/card or under "Manage Brave Ads")
Panel NTP Widget brave://rewards
Image Image Image

Confirmed that where the "Ads seen this month" UI is shown, it updates when a new ad is viewed:

Image Image Image

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Dec 4, 2024 •
edited
Loading

Verification PASSED on

Brave | 1.73.97 Chromium: 131.0.6778.108 (Official Build) (64-bit)
-- | --
Revision | 7e1cc6e3239d93ac39456640abb6b6f8bc51fd39
OS | Windows 10 Version 22H2 (Build 19045.5131)

Verified test plan from brave/brave-core#26751 (comment).

Clean profile (Gemini) - PASSED
  1. Installed 1.73.97.
  2. Launched Brave, close/relaunch to pull griffin
  3. Joined rewards (staging env)
  4. No "Ads seen this month" UI is shown in unconnected state
Example Example Example
Image Image Image
  1. Connected to a custodian

Confirmed:

  • "Ads seen this month" is shown on the panel for both "Contribution" and "Summary" views
  • "Ads seen this month" is shown on the NTP widget
  • "Ads seen this month" is not shown on the wallet section/card of brave://rewards
  • "Total ads received this month" is still shown under "Manage Brave Ads" panel of brave://rewards
  • estimated earnings UI ("Earnings so far"/"Earnings so far this month") is not displayed on the panel, NTP widget, or brave://rewards (wallet section/card or under "Manage Brave Ads")
Panel Panel NTP Widget brave://rewards
Image Image Image Image

Confirmed that where the "Ads seen this month" UI is shown, it updates when a new ad is viewed:

Before After
Image Image
Image Image
Image Image
Image Image

Confirmed that when the month changes (updated system date to Jan 1), "Ads seen this month" resets as expected:

Panel Panel NTP Widget brave://rewards
Image Image Image Image
Upgrade profile (Uphold) - PASSED

Set up a profile using 1.73.91 which was connected to Uphold staging env. Viewed ads, etc prior to updating to 1.73.97. After updating, confirmed:

  • "Ads seen this month" is shown on the panel for both "Contribution" and "Summary" views
  • "Ads seen this month" is shown on the NTP widget
  • "Ads seen this month" is not shown on the wallet section/card of brave://rewards
  • "Total ads received this month" is still shown under "Manage Brave Ads" panel of brave://rewards
  • estimated earnings UI ("Earnings so far"/"Earnings so far this month") is not displayed on the panel, NTP widget, or brave://rewards (wallet section/card or under "Manage Brave Ads")
Panel Panel NTP Widget brave://rewards
Image Image Image Image

Confirmed that where the "Ads seen this month" UI is shown, it updates when a new ad is viewed:

Before After
Image Image
Image Image
Image Image
Image Image

@GeetaSarvadnya GeetaSarvadnya added QA/In-Progress Indicates that QA is currently in progress for that particular issue QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Dec 4, 2024
@LaurenWags LaurenWags mentioned this issue Dec 4, 2024
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@zenparsing zenparsing

Labels
feature/rewards OS/Desktop priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include rewards-2.0
Projects
Brave Rewards
Status: Done
Milestone
1.73.x - Release #3
7 participants
@kjozwiak @zenparsing @Miyayes @LaurenWags @btlechowski @GeetaSarvadnya @brave-builds