Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Follow up to #37961] Title Monthly Subscription is shown once on Leo's settings screen right after purchasing Yearly Subscription #42507

Closed
2 of 5 tasks
hffvld opened this issue Nov 25, 2024 · 2 comments · Fixed by brave/brave-core#26739
Assignees

Comments

@hffvld
Copy link
Contributor

hffvld commented Nov 25, 2024

Description

Follow-up to #37961.

Steps to reproduce

  1. Launch Brave
  2. Purchase Leo Yearly subscription > Wait for the end of activation of the subscription
  3. Land on Leo's settings screen > Observe the title Monthly Subscription

Actual result

The title Monthly Subscription is shown once on Leo's settings screen, right after purchasing the Yearly Subscription and landing settings page for the first time.


1 2
1 2
2024-11-25_12-44-52.mp4

Expected result

When purchasing the corresponding Leo subscription, the title must say Yearly Subscription.


1
1

Reproduces how often

Easily reproduced

Brave version

Brave build: 1.73 (91)
BraveCore: 1.73.91 (131.0.6778.85)

Device/iOS version

iPhone 14 / iOS 17.7.2

Affected browser versions

  • latest AppStore
  • latest TestFlight
  • previous TestFlight

Reproducibility

  • with Brave Shields disabled
  • in the latest version of mobile Safari

Miscellaneous information

cc @Brandon-T

@kjozwiak
Copy link
Member

kjozwiak commented Dec 9, 2024

The above requires 1.74.24 or higher for 1.74.x verification 👍

@Uni-verse Uni-verse added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Dec 11, 2024
@Uni-verse Uni-verse added release-notes/include and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue release-notes/exclude labels Jan 6, 2025
@Uni-verse
Copy link
Contributor

Verified on iPhone 12 running iOS 18.2 using version 1.74 (46)

  • Ensured purchasing Leo yearly subscription is successful and correct subscription type is shown on the settings page.
  • Ensured premium models are working after upgrading.
example example example example example

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants