Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Playlist video duration shown as 0:00 in the track list #42569

Closed
2 of 5 tasks
Uni-verse opened this issue Nov 27, 2024 · 2 comments · Fixed by brave/brave-core#26786
Closed
2 of 5 tasks

Playlist video duration shown as 0:00 in the track list #42569

Uni-verse opened this issue Nov 27, 2024 · 2 comments · Fixed by brave/brave-core#26786

Comments

@Uni-verse
Copy link
Contributor

Description

Playlist video duration is not shown in the track list

Steps to reproduce

  1. New install
  2. Add some videos to playlist
  3. Open Playlist with new UI
  4. Observe the video duration for the items in the drawer

Actual result

Video duration does not shown or loads slowly

Image

Expected result

Should show video duration

Reproduces how often

Easily reproduced

Brave version

1.73.x

Device/iOS version

iPhone, iOS 18

Affected browser versions

  • latest AppStore
  • latest TestFlight
  • previous TestFlight

Reproducibility

  • with Brave Shields disabled
  • in the latest version of mobile Safari

Miscellaneous information

No response

@Uni-verse Uni-verse changed the title Playlist video duration is not shown in the track list Playlist video duration shown as 0:00 in the track list Nov 27, 2024
@kylehickinson
Copy link
Collaborator

Initial investigation shows the videos that fail to show duration are the ones that have blob source urls, once downloaded this doesn't become a problem because we read it directly from the cache but for non-downloaded items we dont have a way to get the duration without first fetching a new src url which only happens after playing it at least once.

  • We may want to hide the duration for these items until its available
  • We may want to update the duration when playing those types of videos and now have the available data

@Uni-verse
Copy link
Contributor Author

Verified on iPhone 12 running iOS 18.2 using version 1.75 (91)

  • Verified video duration is hidden until item is available.
  • Verified correct duration is shown for tracks in the list.
  • Verified selecting Remove Offline Data by long-pressing on playlist item will still display the track duration.
example example
1 2

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants