Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

AI Chat omnibox entry should open full page #42844

Closed
petemill opened this issue Dec 11, 2024 · 1 comment · Fixed by brave/brave-core#26855
Closed

AI Chat omnibox entry should open full page #42844

petemill opened this issue Dec 11, 2024 · 1 comment · Fixed by brave/brave-core#26855
Assignees
@petemill
Labels
browser-ai OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include
Milestone
1.75.x - Release

Comments

@petemill
Copy link
Member

With setting enabled

  1. Enable full page storage
  2. Type "what is an emoji" in omnibox
  3. Select the Leo suggestion

Observe the prompt opens in full page Leo

With setting disabled

  1. Disable full page storage
  2. Type "what is an emoji" in omnibox
  3. Select the Leo suggestion

Observe the prompt opens in sidebar Leo
@petemill petemill self-assigned this Dec 11, 2024
This was referenced Dec 11, 2024
Merged
Closed
@brave-builds brave-builds added this to the 1.75.x - Nightly milestone Dec 12, 2024
@mattmcalister mattmcalister added priority/P2 A bad problem. We might uplift this to the next planned release. browser-ai labels Dec 12, 2024
@mattmcalister mattmcalister moved this to In Progress in Browser AI Dec 12, 2024
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.75.166 Chromium: 132.0.6834.111 (Official Build) beta (64-bit)
Revision 0c5da0a4df158be9400ac84df9312b627cc4dec0
OS Windows 11 Version 24H2 (Build 26100.2894)
  • Verified steps from issue description
  • Verified with Store my conversation history enabled, selecting Ask Leo from omnibar opens Leo in full page view
  • Verified with Store my conversation history disabled, selecting Ask Leo from omnibar opens Leo in sidebar view
42844.mp4

Verification passed on

Brave 1.75.166 Chromium: 132.0.6834.111 (Official Build) beta (64-bit)
Revision 0c5da0a4df158be9400ac84df9312b627cc4dec0
OS Linux
  • Verified steps from issue description
  • Verified with Store my conversation history enabled, selecting Ask Leo from omnibar opens Leo in full page view
  • Verified with Store my conversation history disabled, selecting Ask Leo from omnibar opens Leo in sidebar view
42844.mp4

Verification passed on

Brave 1.75.164 Chromium: 132.0.6834.83 (Official Build) beta (arm64)
Revision befbba8d7568f8713d6f942f9a7350c59b57f20a
OS macOS Version 15.2 (Build 24C101)
  • Verified steps from issue description
  • Verified with Store my conversation history enabled, selecting Ask Leo from omnibar opens Leo in full page view
  • Verified with Store my conversation history disabled, selecting Ask Leo from omnibar opens Leo in sidebar view
42844.mov

@LaurenWags LaurenWags mentioned this issue Feb 5, 2025
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@petemill petemill

Labels
browser-ai OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include
Projects
Browser AI
Status: In Progress
Milestone
1.75.x - Release
4 participants
@mattmcalister @petemill @srirambv @brave-builds