Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[Follow up to #42929] Websites that set a transparent background color render incorrectly in dark mode #43214

Closed
2 of 5 tasks
kylehickinson opened this issue Jan 9, 2025 · 2 comments · Fixed by brave/brave-core#27203
Closed
2 of 5 tasks

[Follow up to #42929] Websites that set a transparent background color render incorrectly in dark mode #43214

kylehickinson opened this issue Jan 9, 2025 · 2 comments · Fixed by brave/brave-core#27203
Assignees
@kylehickinson
Labels
dark mode feature/themes OS/iOS Fixes related to iOS browser functionality QA Pass - iPhone X QA/Yes release/blocking release-notes/include
Milestone
1.75.x - Release

Comments

@kylehickinson
Copy link
Collaborator

Description

Follow up to #42929

Steps to reproduce

  1. Change appearance to dark in app or on device
  2. Visit https://moneywise.com/news/top-stories/ohio-man-bought-entire-street-city-wants-it-back

Actual result

The page background color is transparent and text is black so its unreadable

Image

Expected result

Should be able to read the page

Reproduces how often

Easily reproduced

Brave version

1.75

Device/iOS version

N/A

Affected browser versions

  • latest AppStore
  • latest TestFlight
  • previous TestFlight

Reproducibility

  • with Brave Shields disabled
  • in the latest version of mobile Safari

Miscellaneous information

No response
@kylehickinson kylehickinson added OS/iOS Fixes related to iOS browser functionality QA/Yes release/blocking labels Jan 9, 2025
@kylehickinson kylehickinson self-assigned this Jan 9, 2025
@kylehickinson kylehickinson added this to the 1.75.x - Beta milestone Jan 9, 2025
@kylehickinson kylehickinson mentioned this issue Jan 13, 2025
Merged
24 tasks
@brave-builds brave-builds mentioned this issue Jan 13, 2025
Merged
7 tasks
@kjozwiak
Copy link
Member

The above requires 1.75.160 or higher for 1.75.x verification 👍

@Uni-verse
Copy link
Contributor

Verified on iPhone XR running iOS 17.7 using version 1.75 (164)

Night Mode Dark Mode Light Mode
Image Image Image

@kjozwiak kjozwiak mentioned this issue Feb 11, 2025
Closed
7 tasks
@Uni-verse Uni-verse mentioned this issue Feb 13, 2025
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@kylehickinson kylehickinson

Labels
dark mode feature/themes OS/iOS Fixes related to iOS browser functionality QA Pass - iPhone X QA/Yes release/blocking release-notes/include
Projects
None yet
Milestone
1.75.x - Release
Development

Successfully merging a pull request may close this issue.

[iOS] Only set web view background color when night mode is enabled brave/brave-core
3 participants
@kylehickinson @kjozwiak @Uni-verse