Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Scriptlets wrapper given incorrect value for url comparison #43454

Closed
5 tasks
StephenHeaps opened this issue Jan 23, 2025 · 2 comments · Fixed by brave/brave-core#27320
Closed
5 tasks

Scriptlets wrapper given incorrect value for url comparison #43454

StephenHeaps opened this issue Jan 23, 2025 · 2 comments · Fixed by brave/brave-core#27320
Assignees
@StephenHeaps
Labels
bug feature/shields The overall Shields feature in Brave. OS/iOS Fixes related to iOS browser functionality QA Pass - iPhone QA/Yes regression release-notes/include
Milestone
1.75.x - Release

Comments

@StephenHeaps
Copy link

Description

Ads are displaying on YouTube for some videos

Steps to reproduce

  1. Play some YouTube videos with Shields up (signed out seemed to have better luck)
  2. Verify no ads shown, or metadata shown (0:00/0:06 / 0:00:0:15 timestamps shown before video plays)

Actual result

Ads or ad metadata slips through

Expected result

No ads

Reproduces how often

Easily reproduced

Brave version

1.69 (71)+

Device/iOS version

Any

Affected browser versions

  • latest AppStore
  • latest TestFlight
  • previous TestFlight

Reproducibility

  • with Brave Shields disabled
  • in the latest version of mobile Safari

Miscellaneous information

No response
@StephenHeaps StephenHeaps added bug feature/shields The overall Shields feature in Brave. OS/iOS Fixes related to iOS browser functionality regression labels Jan 23, 2025
@StephenHeaps StephenHeaps self-assigned this Jan 23, 2025
@StephenHeaps StephenHeaps mentioned this issue Jan 23, 2025
Merged
24 tasks
@brave-builds brave-builds added this to the 1.77.x - Nightly milestone Jan 30, 2025
This was referenced Jan 30, 2025
Merged
Merged
@kjozwiak
Copy link
Member

The above requires 1.75.172 or higher for 1.75.x verification 👍

@Uni-verse
Copy link
Contributor

Verified on iPhone 12 running iOS 18.2 using version 1.75 (173)

  • Ensured that no ads are shown when playing YouTube videos.
  • Ensured that scrubbing the progress bar does not show ads.
  • Ensured that next track that plays does not have ads when Autoplay is enabled.
  • Ensured that there are no ads on Youtube for existing users that have upgraded to 1.75.x
example example example
Image Image Image

@kjozwiak kjozwiak mentioned this issue Feb 11, 2025
Closed
7 tasks
@Uni-verse Uni-verse mentioned this issue Feb 13, 2025
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@StephenHeaps StephenHeaps

Labels
bug feature/shields The overall Shields feature in Brave. OS/iOS Fixes related to iOS browser functionality QA Pass - iPhone QA/Yes regression release-notes/include
Projects
None yet
Milestone
1.75.x - Release
Development

Successfully merging a pull request may close this issue.

fix(privacy): FrameCheckWrapper.js given incorrect value for url comparison brave/brave-core
4 participants
@kjozwiak @StephenHeaps @Uni-verse @brave-builds