Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix build failure #43990

Closed
mkarolin opened this issue Feb 14, 2025 · 0 comments · Fixed by brave/brave-core#27668
Closed

Fix build failure #43990

mkarolin opened this issue Feb 14, 2025 · 0 comments · Fixed by brave/brave-core#27668
Assignees
Labels
dev-concern OS/Android Fixes related to Android browser functionality OS/Desktop OS/iOS Fixes related to iOS browser functionality QA/No release-notes/exclude

Comments

@mkarolin
Copy link
Contributor

../../brave/chromium_src/components/omnibox/browser/omnibox_edit_model.cc:11:10: fatal error: 'components/vector_icons/vector_icons.h' file not found
    11 | #include "components/vector_icons/vector_icons.h"
       |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Caused by the //components/vector_icons dep being behind the is_chrome_branded flag while brave/brave-core#27650 needs it not to be.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
dev-concern OS/Android Fixes related to Android browser functionality OS/Desktop OS/iOS Fixes related to iOS browser functionality QA/No release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants