From 231324e6d8b4c2727da2b8065e9211cd6613a539 Mon Sep 17 00:00:00 2001 From: Claudio DeSouza Date: Wed, 9 Oct 2024 01:35:00 +0100 Subject: [PATCH] Fix failure calling `json` function over `cxxbridge` It is not entirely clear what is the underlying mechanism for this failure, and it should be investigated further. On Windows Debug builds, any calls to functions like `json::convert_all_numbers_to_string` were causing a runtime crash. Bisecting our branch has revealed that this crash started after an entirely unrelated change [1] that in fact seems quite anodyne. This change correct the runtime failure with a minimum change. Resolves https://github.com/brave/brave-browser/issues/41497 [1] https://github.com/brave/brave-core/pull/25830 --- browser/sources.gni | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/browser/sources.gni b/browser/sources.gni index 8eaf560a1ea9..9247022ca279 100644 --- a/browser/sources.gni +++ b/browser/sources.gni @@ -117,6 +117,7 @@ brave_chrome_browser_deps = [ "//brave/app:brave_generated_resources_grit", "//brave/browser:browser_process", "//brave/browser:sparkle_buildflags", + "//brave/components/brave_adaptive_captcha", "//brave/browser/brave_adaptive_captcha:impl", "//brave/browser/brave_federated", "//brave/browser/brave_rewards:brave_rewards_impl", @@ -503,7 +504,6 @@ if (is_win && is_official_build) { brave_chrome_browser_public_deps = [ "//brave/app/vector_icons", "//brave/browser:browser_process", - "//brave/components/brave_adaptive_captcha", "//brave/components/brave_sync:constants", "//brave/components/variations", ]