From 6a076d5fa3bf7c00261a3268e822b8974428223d Mon Sep 17 00:00:00 2001 From: Claudio DeSouza Date: Wed, 9 Oct 2024 01:35:00 +0100 Subject: [PATCH] Fix failure calling `json` function over `cxxbridge` It is not entirely clear what is the underlying mechanism for this failure, and it should be investigated further. On Windows Debug builds, any calls to functions like `json::convert_all_numbers_to_string` were causing a runtime crash. Bisecting our branch has revealed that this crash started after an entirely unrelated change [1] that in fact seems quite anodyne. This change correct the runtime failure with a minimum change. Resolves https://github.com/brave/brave-browser/issues/41497 [1] https://github.com/brave/brave-core/pull/25830 --- browser/sources.gni | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/browser/sources.gni b/browser/sources.gni index 8eaf560a1ea9..e0b95cf4cebb 100644 --- a/browser/sources.gni +++ b/browser/sources.gni @@ -497,7 +497,10 @@ if (is_win && is_official_build) { "//chrome/browser/google/switches.h", ] - brave_chrome_browser_deps += [ "//google_update" ] + brave_chrome_browser_deps += [ + "//brave/components/brave_adaptive_captcha", + "//google_update", + ] } brave_chrome_browser_public_deps = [