From a235817fd466f6e1a62bae6e641fe99b7b40a0cf Mon Sep 17 00:00:00 2001 From: Brian Johnson <34129+bridiver@users.noreply.github.com> Date: Sat, 5 Oct 2024 23:32:10 -0700 Subject: [PATCH] fix gn check that broke again with #25799 (#25830) fix gn check that broke again because of an out of order merge of https://github.com/brave/brave-core/pull/25799 --- browser/brave_adaptive_captcha/BUILD.gn | 22 +++++++++++++--------- browser/sources.gni | 3 ++- browser/ui/BUILD.gn | 1 + 3 files changed, 16 insertions(+), 10 deletions(-) diff --git a/browser/brave_adaptive_captcha/BUILD.gn b/browser/brave_adaptive_captcha/BUILD.gn index 11f7792fd89c..c039ac3d45d2 100644 --- a/browser/brave_adaptive_captcha/BUILD.gn +++ b/browser/brave_adaptive_captcha/BUILD.gn @@ -3,18 +3,13 @@ # License, v. 2.0. If a copy of the MPL was not distributed with this file, # You can obtain one at https://mozilla.org/MPL/2.0/. -source_set("brave_adaptive_captcha") { - sources = [ - "brave_adaptive_captcha_service_factory.cc", - "brave_adaptive_captcha_service_factory.h", - ] +source_set("impl") { + visibility = [ "//chrome/browser" ] - public_deps = [ - "//components/keyed_service/content", - "//content/public/browser", - ] + sources = [ "brave_adaptive_captcha_service_factory.cc" ] deps = [ + ":brave_adaptive_captcha", "//base", "//brave/browser/brave_rewards", "//brave/components/brave_adaptive_captcha", @@ -24,3 +19,12 @@ source_set("brave_adaptive_captcha") { "//components/user_prefs", ] } + +source_set("brave_adaptive_captcha") { + sources = [ "brave_adaptive_captcha_service_factory.h" ] + + public_deps = [ + "//components/keyed_service/content", + "//content/public/browser", + ] +} diff --git a/browser/sources.gni b/browser/sources.gni index c57b3c253d62..77e5b63801c9 100644 --- a/browser/sources.gni +++ b/browser/sources.gni @@ -117,6 +117,7 @@ brave_chrome_browser_deps = [ "//brave/app:brave_generated_resources_grit", "//brave/browser:browser_process", "//brave/browser:sparkle_buildflags", + "//brave/browser/brave_adaptive_captcha:impl", "//brave/browser/brave_federated", "//brave/browser/brave_rewards:brave_rewards_impl", "//brave/browser/brave_rewards:util", @@ -138,7 +139,6 @@ brave_chrome_browser_deps = [ "//brave/components/ai_chat/core/common/buildflags", "//brave/components/ai_rewriter/common/buildflags", "//brave/components/body_sniffer", - "//brave/components/brave_adaptive_captcha", "//brave/components/brave_ads/browser", "//brave/components/brave_ads/core", "//brave/components/brave_component_updater/browser", @@ -501,6 +501,7 @@ if (is_win && is_official_build) { brave_chrome_browser_public_deps = [ "//brave/app/vector_icons", "//brave/browser:browser_process", + "//brave/components/brave_adaptive_captcha", "//brave/components/brave_sync:constants", "//brave/components/variations", ] diff --git a/browser/ui/BUILD.gn b/browser/ui/BUILD.gn index a5168472843b..287bd94e3c67 100644 --- a/browser/ui/BUILD.gn +++ b/browser/ui/BUILD.gn @@ -48,6 +48,7 @@ source_set("ui") { ] deps = [ + "//brave/browser/brave_adaptive_captcha", "//brave/browser/brave_rewards", "//brave/browser/skus", "//brave/components/brave_shields/core/browser",