You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on May 10, 2024. It is now read-only.
The bottom and top toolbars are currently a bit goofy. One of the main reasons being how intelligent they are about their own coloring states. It was compounded further when individual top and bottom toolbar coloring was supported (e.g. TabsButton(top: true)) via #1324 1493
This is probably best done by appearance() (see AppearanceExtensions.swift).
Specific button colors can be manipulated based on their parent container:
e.g. (something like, the below pseudo-code):
ToolbarButton.appearance(whenContainedInInstancesOf: [TopToolbar.self]).appearanceBackgroundColor = // some color
At least these places should be cleaned up:
ToolbarButton
TabsButton
Test Plan
iPhone:
Verify top and bottom toolbar coloring works for all themes
Verify top and bottom toolbar buttons are correctly colored for all themes
iPad:
Verify top toolbar coloring works for all themes
Verify top toolbar buttons are correctly colored for all themes
The text was updated successfully, but these errors were encountered:
Description
The bottom and top toolbars are currently a bit goofy. One of the main reasons being how intelligent they are about their own coloring states. It was compounded further when individual top and bottom toolbar coloring was supported (e.g.
TabsButton(top: true)
) via #1324 1493This is probably best done by
appearance()
(seeAppearanceExtensions.swift
).Specific button colors can be manipulated based on their parent container:
e.g. (something like, the below pseudo-code):
At least these places should be cleaned up:
Test Plan
iPhone:
iPad:
The text was updated successfully, but these errors were encountered: