Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Toolbar Theming Cleanup #1494

Closed
6 tasks
jhreis opened this issue Sep 6, 2019 · 1 comment
Closed
6 tasks

Toolbar Theming Cleanup #1494

jhreis opened this issue Sep 6, 2019 · 1 comment

Comments

@jhreis
Copy link
Contributor

jhreis commented Sep 6, 2019

Description

The bottom and top toolbars are currently a bit goofy. One of the main reasons being how intelligent they are about their own coloring states. It was compounded further when individual top and bottom toolbar coloring was supported (e.g. TabsButton(top: true)) via #1324 1493

This is probably best done by appearance() (see AppearanceExtensions.swift).

Specific button colors can be manipulated based on their parent container:
e.g. (something like, the below pseudo-code):

ToolbarButton.appearance(whenContainedInInstancesOf: [TopToolbar.self]).appearanceBackgroundColor = // some color

At least these places should be cleaned up:

  • ToolbarButton
  • TabsButton

Test Plan

iPhone:

  • Verify top and bottom toolbar coloring works for all themes
  • Verify top and bottom toolbar buttons are correctly colored for all themes

iPad:

  • Verify top toolbar coloring works for all themes
  • Verify top toolbar buttons are correctly colored for all themes
@jhreis jhreis added enhancement QA/Yes release-notes/exclude Epic: Cleanup Epic for cleaning up internals of the project, primary refactoring or removing dead code. labels Sep 6, 2019
@iccub iccub removed Epic: Cleanup Epic for cleaning up internals of the project, primary refactoring or removing dead code. QA/Yes enhancement release-notes/exclude labels May 6, 2021
@iccub
Copy link
Contributor

iccub commented May 6, 2021

Invalid since the new theming changes #3606

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

No branches or pull requests

2 participants