Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Changing theme while ad notification causes weird theme issues #2053

Closed
srirambv opened this issue Nov 28, 2019 · 1 comment · Fixed by #3606
Closed

Changing theme while ad notification causes weird theme issues #2053

srirambv opened this issue Nov 28, 2019 · 1 comment · Fixed by #3606

Comments

@srirambv
Copy link
Contributor

Description:

Changing theme via control center when an ad notification on screen causes theming issue on the browser. The only way to fix it is to remove the app from memory and relaunch

Steps to Reproduce

  1. Set device theme to dark
  2. Enable rewards and wait till you get an ad
  3. While ad is shown change theme via control center
  4. Clear browsing data after dismissing the notification
  5. New tab has dark and white theme mixed
  6. Shields also has dark theme on both new tab and on page

Actual result:
image
image
image

Expected result:
No theme issue

Reproduces how often: [Easily reproduced, Intermittent Issue]
Easy

Brave Version:
1.14(19.11.27.22)

Device details:
iPhone

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information

Possibly related to #2044

@srirambv
Copy link
Contributor Author

Verification passed on iPhone XR with iOS 13.5 running 1.26(21.5.25.18)

  • Verified steps from issue description
  • Verified changing theme when an ad notification is shown doesn't cause any theme issues

Verification passed on iPhone 7+ with iOS 14.5.1 running 1.26(21.5.25.18)

  • Verified steps from issue description
  • Verified changing theme when an ad notification is shown doesn't cause any theme issues

Verification passed on iPad Pro with iOS 14.5.1 running 1.26(21.5.25.18)

  • Verified steps from issue description
  • Verified changing theme when an ad notification is shown doesn't cause any theme issues

# for free to subscribe to this conversation on GitHub. Already have an account? #.