Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Only round up token balance or transaction amount for displaying. #5247

Closed
nuo-xu opened this issue Apr 12, 2022 · 1 comment · Fixed by #5253
Closed

Only round up token balance or transaction amount for displaying. #5247

nuo-xu opened this issue Apr 12, 2022 · 1 comment · Fixed by #5253
Assignees
@nuo-xu
Labels
bug Epic: Brave Wallet QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Milestone
1.38

Comments

@nuo-xu
Copy link
Contributor

nuo-xu commented Apr 12, 2022

Currently we round up amount for token balance and gasFee.
This could cause an issue that transaction amount is greater than available balance.
Add unit test.
@nuo-xu nuo-xu added this to Web3 Apr 12, 2022
@nuo-xu nuo-xu self-assigned this Apr 12, 2022
@nuo-xu nuo-xu moved this to In Progress in Web3 Apr 13, 2022
@nuo-xu nuo-xu mentioned this issue Apr 13, 2022
Merged
7 tasks
Repository owner moved this from In Progress to Done in Web3 Apr 14, 2022
@nuo-xu nuo-xu added this to the 1.38 milestone Apr 14, 2022
@srirambv
Copy link
Contributor

Verification passed on the following devices running 1.38 (22.4.25.12)

  • iPhone 7+ (iOS 14.8.1)
  • iPhone XR (iOS 15.4.1)
  • iPad Pro (iOS 15.5 Beta 3)
  • Verified steps from #5253
  • Verified value is only rounded up for display but is using the full value for transactions
ERC Send ERC Swap
ERC.Send.mp4
ERC.Swap.mp4

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees

@nuo-xu nuo-xu

Labels
bug Epic: Brave Wallet QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.38
Development

Successfully merging a pull request may close this issue.

Fix 5247: No rounding if users want to send/swap full token balance brave/brave-ios
2 participants
@nuo-xu @srirambv