This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Use language name for sort order instead of identifier. Fix a few outdated comments #4055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dated comments. Issue: #3955 Auditors: @bbondy, @alexwykoff Test Plan: i. Open about:preferences ii. Ensure language are in alphabetical order in select
|
With this change, the languages will be sorted by their English names. This could be a little confusing for non-English users since the language list has no logical order in their language (the language names themselves are localized). If we go with sorting by language name, I suggest we also sort the list in other languages. (Another issue should be opened for that, though.) |
|
I strongly agree, How about following Wikipedia? |
|
no objection since it doesn't make it worse but I think doing a sort within the render in react would be better because it would work with all langs |
This was referenced Sep 22, 2016
This was referenced Sep 24, 2016
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #3955
Auditors: @bbondy, @alexwykoff
Test Plan:
i. Open about:preferences
ii. Ensure languages are in alphabetical order in select