Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Sort adblock filter lists alphabetically #4501

Closed
luixxiul opened this issue Oct 4, 2016 · 7 comments
Closed

Sort adblock filter lists alphabetically #4501

luixxiul opened this issue Oct 4, 2016 · 7 comments

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Oct 4, 2016

Test plan

  1. Open about:adblock
  2. a, b, c, d, ...

To sort adblock filter lists alphabetically,

you can just modify this file for the abp-filter-parser-cpp library:
https://github.com/bbondy/abp-filter-parser-cpp/blob/master/lib/regions.js and update the package.json version’s Z by a x.y.Z

The fix is just to re-order that array of objects.

@alexwykoff alexwykoff added this to the 1.0.0 milestone Nov 4, 2016
@luixxiul luixxiul modified the milestones: 1.0.0, contributor backlog Feb 5, 2017
@Jacalz
Copy link
Contributor

Jacalz commented Feb 22, 2017

I have organized it by the first three letters but i wonder why is there a IRN adblock filter for iran that doesent show in settings?

@Jacalz
Copy link
Contributor

Jacalz commented Feb 22, 2017

Here is the adblock list ordered in alpabetical order and I made a pull request for it in brave/ad-block:
brave-experiments/ad-block#52

@luixxiul
Copy link
Contributor Author

why is there a IRN adblock filter for iran that doesent show in settings?

I'm not sure. CC @bbondy for a comment.

@Jacalz
Copy link
Contributor

Jacalz commented Feb 27, 2017

I would love if someone could merge my pull request in brave/ad-block and then close this issue 👍
Or just give me feedback on something to change if needed 😄 @luixxiul

@srirambv
Copy link
Collaborator

Moving to 0.19.x as the fix is only done on brave-experiments/ad-block#66. There is no browser-laptop work done.

@srirambv
Copy link
Collaborator

This isnt implemented on browser-laptop yet. Should this be moved out of 0.19.x?

@bbondy bbondy removed this from the 0.19.x (Beta Channel) milestone Sep 20, 2017
@bbondy bbondy added this to the 0.21.x (Nightly Channel) milestone Sep 20, 2017
@bbondy bbondy reopened this Sep 20, 2017
@bbondy bbondy modified the milestones: 0.21.x (Developer Channel), 0.20.x (Beta Channel) Oct 25, 2017
@bsclifton bsclifton added this to the Triage Backlog milestone Nov 27, 2017
@srirambv
Copy link
Collaborator

This looks fixed on 0.19.123. Closing the issue
image

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

No branches or pull requests

6 participants