Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Uploading images on Github "New Issue" fails #6925

Closed
dignifiedquire opened this issue Jan 30, 2017 · 8 comments
Closed

Uploading images on Github "New Issue" fails #6925

dignifiedquire opened this issue Jan 30, 2017 · 8 comments
Labels
duplicate Issue has already been reported feature/adblock

Comments

@dignifiedquire
Copy link

dignifiedquire commented Jan 30, 2017

  • Describe the issue you encountered: When either dragging and dropping or selecting an image to be uploaded to a github issue, there will be an error from Github saying that it was not able to upload the image.
  • Platform (Win7, 8, 10? macOS? Linux distro?): macOS 10.12.3
  • Brave Version (revision SHA): 719b6f89fc81ae65c4162cfcb4daba17423897ef (master)
  • Steps to reproduce:
    1. Visit https://github.com/brave/browser-laptop/issues/new
    2. Drag and drop image into the issue field
    3. See error message appear
  • Actual result: Image is not uploaded to github
  • Expected result: Image is uploaded to github and shown in the issue comment
  • Will the steps above reproduce in a fresh profile? Yes
  • Can this issue be consistently reproduced? Yes
  • Screenshot if needed:

screen shot 2017-01-30 at 17 12 07

@cndouglas
Copy link

All three image upload options on GitHub work fine for me with Brave 0.13.0 on macOS 10.12.3.

@NejcZdovc
Copy link
Contributor

Everything works ok for me as well

@dignifiedquire
Copy link
Author

Is this working for you in master as well?

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Jan 30, 2017

image

I was testing it with a released version, because I use it every day and today I think I uploaded about 5 to 6 images. But I know that @bsclifton had some problems yesterday with image upload to Github

@cndouglas
Copy link

Works fine for me with a14fcdf.

@luixxiul
Copy link
Contributor

luixxiul commented Jan 31, 2017

Do you enable any custom filters on about:adblock?

@dignifiedquire
Copy link
Author

I figured out where the issue is coming from. I had enabled JPN: ABP Japanese filters (日本用フィルタ)and disabling those fixes things.

@luixxiul
Copy link
Contributor

OK then I think it is okay to close this as a duplicate of #6883

@luixxiul luixxiul added duplicate Issue has already been reported feature/adblock labels Jan 31, 2017
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
duplicate Issue has already been reported feature/adblock
Projects
None yet
Development

No branches or pull requests

4 participants