Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Url bar icon bookmark save is not working #8151

Closed
NejcZdovc opened this issue Apr 9, 2017 · 1 comment
Closed

Url bar icon bookmark save is not working #8151

NejcZdovc opened this issue Apr 9, 2017 · 1 comment
Assignees
@bbondy
Labels
bug feature/navbar misc/drag-and-drop QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.15.0

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Apr 9, 2017 •
edited by luixxiul
Loading

Test plan

62665a5

  • Did you search for similar issues before submitting this one?
    yes

  • Describe the issue you encountered:
    You can't bookmark the current site with a dnd of a url bar icon

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    all

  • Brave Version (revision SHA):
    e62991c

  • Steps to reproduce:

    1. go to https://clifton.io
    2. dnd lock icon onto bookmark

  • Actual result:
    image

  • Expected result:
    Page is added to bookmarks

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    yes

  • Is this an issue in the currently released version?
    yes

  • Can this issue be consistently reproduced?
    yes
@NejcZdovc NejcZdovc self-assigned this Apr 9, 2017
@NejcZdovc NejcZdovc added this to the 0.14.3 milestone Apr 9, 2017
@NejcZdovc NejcZdovc added the bug label Apr 9, 2017
@NejcZdovc
Copy link
Contributor Author

NejcZdovc commented Apr 9, 2017 •
edited
Loading

This was broken in this commit 5837fc5, because this.activeFrame is not defined anymore (https://github.com/brave/browser-laptop/blob/master/app/renderer/components/urlBarIcon.js#L92). Fix should be quite easy.

cc @bsclifton

@bsclifton bsclifton modified the milestones: 0.14.2, 0.14.3 Apr 9, 2017
@bsclifton bsclifton assigned bsclifton and unassigned NejcZdovc Apr 9, 2017
@bbondy bbondy closed this as completed in 62665a5 Apr 10, 2017
@bsclifton bsclifton assigned bbondy and unassigned bsclifton Apr 10, 2017
This was referenced Apr 13, 2017
Closed
Closed
Closed
This was referenced Apr 21, 2017
Closed
Closed
@alexwykoff alexwykoff mentioned this issue Apr 25, 2017
Closed
@alexwykoff alexwykoff changed the title Url bar icon bookmark save is not working Fixed creating a bookmark by dragging the Url bar icon Apr 25, 2017
@luixxiul luixxiul changed the title Fixed creating a bookmark by dragging the Url bar icon Url bar icon bookmark save is not working Oct 17, 2017
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees

@bbondy bbondy

Labels
bug feature/navbar misc/drag-and-drop QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.15.0
Development

No branches or pull requests
7 participants
@bbondy @alexwykoff @luixxiul @cezaraugusto @bsclifton @NejcZdovc @srirambv