Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

incorrect hostname shown in titlemode when host is very long #9500

Closed
diracdeltas opened this issue Jun 15, 2017 · 1 comment · Fixed by #9501
Closed

incorrect hostname shown in titlemode when host is very long #9500

diracdeltas opened this issue Jun 15, 2017 · 1 comment · Fixed by #9501

Comments

@diracdeltas
Copy link
Member

issue exists in 0.17.x but is fixed in 0.18.x by #9154

  1. go to https://longextendedsubdomainnamewithoutdashesinordertotestwordwrapping.badssl.com/
  2. mouse away from the urlbar to enter title mode
  3. the origin is shown as 'longextendedsubdomainnamewithoutdashesinordertotestwordwrapping' instead of 'longextendedsubdomainnamewithoutdashesinordertotestwordwrapping.badssl.com'
@diracdeltas diracdeltas added this to the 0.17.x (Beta Channel) milestone Jun 15, 2017
@diracdeltas
Copy link
Member Author

diracdeltas commented Jun 15, 2017

i verified that this is fixed by using node's url.parse instead of https://github.com/petkaantonov/urlparser/blob/master/src/urlparser.js, which we shouldn't use anyway because it appears to no longer be maintained.

it is also fixed by using muon.url.parse

# for free to subscribe to this conversation on GitHub. Already have an account? #.