Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add a button to expand all cards #33

Open
brittanyrw opened this issue Sep 24, 2019 · 2 comments
Open

Add a button to expand all cards #33

brittanyrw opened this issue Sep 24, 2019 · 2 comments
Assignees
Labels
CSS Issue requires modification of CSS javascript Issue requires modification of JavaScript

Comments

@brittanyrw
Copy link
Owner

Add a button on the homepage that will toggle showing and hiding the song name. This button will allow people to show all names if they just want to browse vs having to click on each card to see the name.

When you click on the button it should toggle, ie if I click and nothing is expanded, everything will expand and then when I click again, everything should hide again.

Let us know if you want assistance with the design for this! Otherwise, feel free to come up with something on your own.

@brittanyrw brittanyrw added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers hacktoberfest CSS Issue requires modification of CSS javascript Issue requires modification of JavaScript labels Sep 24, 2019
@iryb
Copy link

iryb commented Sep 26, 2019

Hey! I would like to help you. Please tell where the button should appear? I guess between the header and books section?

@brittanyrw
Copy link
Owner Author

@burianovata Yes, it can go there if you like! I am pretty flexible with this. 🙂 It could go in the top right corner, inside of the header section...etc. Just as long as people can easily use it.

You can see an example of how someone implemented this on EmojiScreen. It's the purple button with the eye icon. They decided to but it in the bottom right of the screen.

Screen Shot 2019-09-26 at 7 38 07 AM

@brittanyrw brittanyrw removed hacktoberfest good first issue Good for newcomers help wanted Extra attention is needed labels Oct 1, 2019
@brittanyrw brittanyrw added help wanted Extra attention is needed and removed help wanted Extra attention is needed enhancement New feature or request labels Sep 30, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
CSS Issue requires modification of CSS javascript Issue requires modification of JavaScript
Projects
None yet
Development

No branches or pull requests

2 participants