-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Accessibility Updates #37
Comments
I ran both AXE and Accessibility Insights on emojipages, the only issue was a missing lang attribute on the html element. I will open a PR for this. Do you have any ideas for handling alt text on the emojis? |
Setting the font-size to 200% (one of the things in the accessibility checklist) causes the grid to go wider than the viewport. This can be fixed using a grid layout like repeat(auto-fill, minmax(200px, 1fr)). This might not be an issue following the fixes made in issue #217 ? |
@david-webber We don't have to add alt text on the emojis, it is built in. For example, if you use a voice over tool to read out what is on a webpage, it will read the official name of the emoji. So for example 😂this one is "Face With Tears of Joy" and this one is 🤣"Rolling on the Floor Laughing". Okay, I will try to merge that other Issue in soon then we can see about the font sizing. Another accessibility item that can be updated is the focus outline that shows up when you navigate the site using tab. Right now it is the default blue color. Examples below around the button and cards: Since the background is so dark, it is a little hard to see the focus. We can change the color so that it is more prominent and also make it so that the focus isn't touching the edge of what it is surrounding so that it is easier to see what we are focusing on. So like this for example if the focus was white and had an offset: But the focus for the hint icon will need to be a different color or remain the default blue because this is what it looks like white: Let me know if you'd like to tackle that one. |
Oh I had no idea emojis we're accessible by default, that's cool! Yeah I'll take a look at the outline issue tomorrow or the next day and then I'll do the pull request. Thanks. |
Hi @brittanyrw - I see you have now opened this up again. I made some changes for this last week before you closed it, I have modified the focus state for the contribute-callout button and the emoji-images class. I have added a slight box-shadow to the focus state on the emoji-images class and :after element. Please see preview of my changes, if you would like me to make any other changes let me know, if not I will open a PR. Thanks. |
Make sure that EmojiPages is fully accessible.
You can either make accessibility updates yourself or create Issues for things that need to be updated.
The text was updated successfully, but these errors were encountered: