Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

OnPopState calls in case of section change #487

Open
bcsongi opened this issue Mar 5, 2020 · 0 comments
Open

OnPopState calls in case of section change #487

bcsongi opened this issue Mar 5, 2020 · 0 comments

Comments

@bcsongi
Copy link

bcsongi commented Mar 5, 2020

In case of section change in the current page I call a link like:
http://localhost:8080/page/xxxid#section-How+does+Test+work%3F

We use also tab changes on the page, which look like
http://localhost:8080/page/xxxid

onPopState state function calls every time when I use this links, and modify the link on a wrong way when I use section change (remove the id):
http://localhost:8080/wiki/section-How+does+Test%3F

I could fix it on that way that I override the onPopState event handler like:
History.onPopState = function(event,extra){
if (History.getLocationHref().indexOf("#")!==-1) return;
..

Please fix it!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant