Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

New Pull Request whitout conflicts #5

Merged
merged 4 commits into from
Nov 15, 2020
Merged

Conversation

andr3slelouch
Copy link
Contributor

Hey, I resolved the conflict on my fork, checkout please.

This fork is for everyone as me that have trouble with subprocess.run, that brotab was not accepting any arguments, son i decided to implement the same functionality importing the brotab package and just calling the respective functions.
Created option to close tabs with keyboard cltab, cl or clt, due to limitations on my undertanding of how to manage it it is limited for that words.
@andr3slelouch andr3slelouch changed the title New Pull Request whitout coflicts New Pull Request whitout conflicts Jul 2, 2020
@brpaz brpaz self-assigned this Nov 14, 2020
@brpaz
Copy link
Owner

brpaz commented Nov 15, 2020

Sorry for the delay.

I have tested your PR. LGTM.

Thanks.

@brpaz brpaz merged commit e60d117 into brpaz:master Nov 15, 2020
@andr3slelouch
Copy link
Contributor Author

Nice :3

github-actions bot pushed a commit that referenced this pull request Jun 15, 2022
# 1.0.0 (2022-06-15)

### Bug Fixes

* add missing keyword ([438d8f5](438d8f5))
* add missing keyword ([53537dd](53537dd))

### Features

* initial commit ([ed519d7](ed519d7))
* refactor tabs cache system and some code cleanup ([a56e251](a56e251))
* Refactor to use brotab Python client directly ([#5](#5)) ([e60d117](e60d117))
* small improvments ([de2e58d](de2e58d))
@github-actions
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants