Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

buf mod update should disregard buf.yaml#name in workspaces #1384

Closed
wingsofovnia opened this issue Sep 7, 2022 · 1 comment
Closed

buf mod update should disregard buf.yaml#name in workspaces #1384

wingsofovnia opened this issue Sep 7, 2022 · 1 comment
Labels
Bug Something isn't working

Comments

@wingsofovnia
Copy link

As many other users, I recently discovered my local workspace is broken due to #1380:

❯ buf lint team-project
Failure: buf.build/googleapis/googleapis:cac7f97f0d3a4c3d9d2004f475c0553c: does not exist

I tried updating the dependency but got this:

❯ buf mod update team-project
Failure:

Which after updating to the latest buf turned into:

❯ buf mod update team-project
Failure: 404 Not Found

By trial and error I found out removing team-project/buf.yaml#name solves the issue:

version: v1
# name: example.com/team/project # uncomment me after running buf mod update
deps:
  - buf.build/googleapis/googleapis

Although name is not needed in local workspaces, which mine is, I am using non-buf.build repo (example.com) for analyzing which inter-module dependencies are local and which ones come from buf.build (external) by looking at a Buf image (ModuleInfo).

I believe buf mod update should disregard name in workspaces/unpublished modules/custom domains and do only and exactly what its --help says: Update a module's dependencies by updating the buf.lock file.

@joshcarp joshcarp added the Bug Something isn't working label Sep 22, 2022
@doriable
Copy link
Member

doriable commented Jun 5, 2024

This should now be valid -- as long as the name is a proper module name (e.g. example.com/team/project), it will update the dependencies. Closing this, if there are other concerns, please feel free to re-open.

@doriable doriable closed this as completed Jun 5, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants