Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Allow mutable tags #1415

Closed
julienrbrt opened this issue Sep 19, 2022 · 6 comments
Closed

Allow mutable tags #1415

julienrbrt opened this issue Sep 19, 2022 · 6 comments
Labels

Comments

@julienrbrt
Copy link

We are using buf for the cosmos/cosmos-sdk, and lately, we are encountering missing commits. This breaks our need of proto versioning and our upgrade documentation (e.g., https://github.com/cosmos/cosmos-sdk/blob/main/UPGRADING.md#protobuf-1)

Failure: buf.build/cosmos/cosmos-sdk:106f3380b73b4157a9e0149cbd30bf9f: does not exist
Failure: buf.build/cosmos/cosmos-sdk:af8d763f189a4482b59f9f283b446293: does not exist.

AFAIK, commits are immutable, and we can find it in the commit history: https://buf.build/cosmos/cosmos-sdk/commits/af8d763f189a4482b59f9f283b446293 but without content. Only the recent commits are available.

@julienrbrt julienrbrt changed the title Missing commits for buf.build/cosmos/cosmos-sdk Missing commits content for buf.build/cosmos/cosmos-sdk Sep 19, 2022
@robbertvanginkel
Copy link
Contributor

While commits are indeed immutable on the BSR, the repository in which they exist can be deleted. It looks like cosmos-sdk has a dependency on buf.build/googleapis/googleapis, which was recently deleted and re-created (please see #1380 for more context on that).

Unfortunately, the error message that is propagated to the cli and website aren't clear about this and make it seem like it is a problem with the cosmos module rather than one of its dependencies. We're currently working on getting more descriptive errors into the cli and the website. I'll leave this open till we improve that, but for the root cause or any other comments on how the googleapis recreation has impacted I'll ask that we centralize that discussion in #1380.

@julienrbrt
Copy link
Author

That's unfortunate…
Say I need a buf commit linked to a tag, but because the commit content is deleted, I cannot access it. Am I able to push another commit with the same tag (I don't think so, but maybe I am missing something)?

@robbertvanginkel
Copy link
Contributor

Tags cannot be deleted today, #765 tracks some work related to changing that but I have nothing concrete to share there yet.

@bufdev
Copy link
Member

bufdev commented Jan 14, 2023

We're going to potentially be making changes to tags to allow this in the near future. Will keep this issue open as we update you on that.

@bufdev bufdev changed the title Missing commits content for buf.build/cosmos/cosmos-sdk Allow mutable tags Jan 14, 2023
@bufdev bufdev added the BSR label Jan 14, 2023
@doriable
Copy link
Member

Tags are now labels, and labels are mutable: https://buf.build/docs/concepts/commits-labels#labels
Going to close this for now, feel free to re-open if there are any questions or concerns.

@julienrbrt
Copy link
Author

This is perfect, thank you!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants