Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

holiday indicator, day after /before holiday indicator functionality #160

Open
alejandrohagan opened this issue Nov 29, 2023 · 1 comment

Comments

@alejandrohagan
Copy link

Hi Matt

Great package -- honestly the package for time series of modeling out of any language. Thank you.

I noticed in the python port that the equivalent timetk::tk_augment_holiday_signature() will return the not just a holiday indicator but also the day before and day after holiday indicator.

Can this functionality be brought to the R package?

Also I've noticed it will flag the day of the holiday however if the holiday falls on a sat/sun usually the weekday after that is a public holiday -- however there is no way to flag that. Is it possible to flag not just the holiday but the public holiday it will trigger?

@joranE
Copy link
Contributor

joranE commented Nov 30, 2023

I have accomplished this sort of effect using the extrasteps package, e.g. the steps step_time_event(), step_date_before(), step_date_after(), etc. Those recipe steps lean heavily on the almanac package so be sure to familiarize yourself with almanac, as the documentation in the extrasteps package is a little sparse, as the steps there are still slightly experimental.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants