Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Review performance optimization of makeHetHomozygotes #7

Closed
akotlar opened this issue Jul 30, 2018 · 1 comment
Closed

Review performance optimization of makeHetHomozygotes #7

akotlar opened this issue Jul 30, 2018 · 1 comment

Comments

@akotlar
Copy link
Collaborator

akotlar commented Jul 30, 2018 •
edited
Loading

Function was written as is to minimize CPU time, as is the case for all functions of the program. This means that 1) functions are manually inlined, 2) common cases are considered independently. It may turn out to be the case that ~40% of the code can be removed, as long as alt[:4] and alt == "0|0" perform similarly. Similarly, it may be possible to rely on compiler inlining more. This primarily related to makehetHomozygotes.

Related to #4
@akotlar akotlar mentioned this issue Jan 4, 2024
Merged
@akotlar
Copy link
Collaborator Author

akotlar commented Jan 13, 2024 •
edited
Loading

This was done in PR #11

@akotlar akotlar closed this as completed Jan 13, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@akotlar