Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Minor documentation updates to docs/WASI-tutorial.md #6839

Merged
merged 2 commits into from
Aug 14, 2023

Conversation

JiaT75
Copy link
Contributor

@JiaT75 JiaT75 commented Aug 11, 2023

Hi!

I was working through your tutorial in the beginning of my journey to port something to be able to run in wasi-sdk. This PR should fix a minor copy/paste error and update some of the error messages.

wasi-sdk version: 20.11gf3b43c703f1a (compiled/installed from source)
wasmtime-cli: 11.0.1

I hope this helps!

JiaT75 added 2 commits August 11, 2023 23:34
The `cat /tmp/somewhere.txt` command in the example using --dir=$PWD is not needed. The error message should be after the first command anyway since it should be the one creating the message.

It looks like a copy/paste error since the previous example showed the same `cat` command a successful copy.
The error messages appear to have changed since this document was originally written.
@github-actions github-actions bot added the wasmtime:docs Issues related to Wasmtime's documentation label Aug 11, 2023
@pchickey pchickey added this pull request to the merge queue Aug 14, 2023
Merged via the queue into bytecodealliance:main with commit 79f3345 Aug 14, 2023
eduardomourar pushed a commit to eduardomourar/wasmtime that referenced this pull request Aug 18, 2023
…e#6839)

* Docs: Remove unneeded command in WASI-tutorial.md

The `cat /tmp/somewhere.txt` command in the example using --dir=$PWD is not needed. The error message should be after the first command anyway since it should be the one creating the message.

It looks like a copy/paste error since the previous example showed the same `cat` command a successful copy.

* Docs: Update error messages in WASI-tutorial.md.

The error messages appear to have changed since this document was originally written.
geekbeast pushed a commit to geekbeast/wasmtime that referenced this pull request Aug 18, 2023
…time into feature/wasi-nn-preview-2

* 'feature/wasi-nn-preview-2' of github.com:geekbeast/wasmtime:
  Memcheck for Wasm guests in Wasmtime (bytecodealliance#6820)
  CI: upgrade to qemu 8.0.4. (bytecodealliance#6849)
  Sync wasi-cli with wit definitions in standards repo  (bytecodealliance#6806)
  Rename `preview2::preview2` to `preview2::host` (bytecodealliance#6847)
  winch: Simplify the MacroAssembler and Assembler interfaces (bytecodealliance#6841)
  There are no files in `preview1` other than `mod.rs` (bytecodealliance#6845)
  Update stdio on Unix to fall back to worker threads (bytecodealliance#6833)
  Update RELEASES.md (bytecodealliance#6838)
  Minor documentation updates to docs/WASI-tutorial.md (bytecodealliance#6839)
  Add support for vector in DataValueExt::int() (bytecodealliance#6844)
@nyabinary
Copy link

This user is malicious by the way, just wanted to let you all know :3 cc: @pchickey

@Suya1671
Copy link

considering its a doc change I doubt this would have a backdoor in it :). We also don't know if it's was caused by a compromised account or was indeed malicious afaik. This is probably not the place to discuss that though

@sunfishcode
Copy link
Member

Yes, we're aware of the situation here, and, if anyone has new information to report, please follow the Bytecode Alliance security process and report it to security@bytecodealliance.org.

@fitzgen
Copy link
Member

fitzgen commented Apr 4, 2024

Blog post on bytecodealliance.org about this pull request: https://bytecodealliance.org/articles/xz-backdoor-and-wasmtime

@bytecodealliance bytecodealliance locked as resolved and limited conversation to collaborators Apr 4, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
wasmtime:docs Issues related to Wasmtime's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants