Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add debug annotation on workload #23

Open
jonathan-mayer opened this issue Aug 9, 2024 · 0 comments
Open

Add debug annotation on workload #23

jonathan-mayer opened this issue Aug 9, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@jonathan-mayer
Copy link
Member

Issue

Currently if the configuration is valid, but isn't doing what the user wants there is no simple way to find out what the problem is other than asking someone for help or asking an admin to enable debug mode, filter through logs and find what the downscaler is doing.

Problem to solve

Implement a downscaler/debug flag on the workload, this flag is special as it isn't a layer value, nor a run time argument (maybe find a good name for such values). The resourceLogger needs a new function for handling Debug Events.

Further details

Logs should include:

  • Scaling outcome: up, down, (also reasons for skips: original replicas not set, excluded, already at downscale replicas)
  • (look for other logs to include)

Proposal

Do the above.
Try not to copy the whole corev1.event{...} struct from the other function, maybe make a private func that they share.

Who can address the issue

Go Dev

Other links/references

@jonathan-mayer jonathan-mayer added the enhancement New feature or request label Aug 9, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant