Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Bug] held property doesn't work if raw_binding_map use to override layer icon #113

Closed
dhruvinsh opened this issue Sep 13, 2024 · 3 comments

Comments

@dhruvinsh
Copy link
Contributor

Minimal config that breaks the held highlighting.

draw_config:
  dark_mode: auto

parse_config:
  raw_binding_map:
    # Layers
    "&lt NAV ESC":
      tap: $$mdi:keyboard-esc$$
      hold: NAV
    "&lt NUM SPACE":
      tap: $$mdi:keyboard-space$$
      hold: NUM
    "&lt SYM BSPC":
      tap: $$mdi:backspace$$

Without raw_binding_map:
image

With raw_binding_map:

image
@caksoylar
Copy link
Owner

The way raw_binding_map is used right now, it completely short circuits the usual processing if the key is found in the mapping. This includes analyzing the binding to see if it is a layer activator. I could see changing this, but I am curious if you have a practical use case for this where you'd need it, as opposed to using instead e.g.

parse_config:
  zmk_keycode_map:
    ESC: $$mdi:keyboard-esc$$
    SPACE: $$mdi:keyboard-space$$

@dhruvinsh
Copy link
Contributor Author

dhruvinsh commented Sep 13, 2024

The way raw_binding_map is used right now, it completely short circuits the usual processing if the key is found in the mapping.

Yeah the name raw make sense.

if you have a practical use case for this where you'd need it
I was using to override how the Layer name appear.

For now I have switched to using zmk_keycode_map. If the idea of raw_binding_map of no processing and you plan to keep that way I am all okay for it.

@caksoylar
Copy link
Owner

I'll close this since I don't have plans to change that in the near future.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants