You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, the alignment for all combos seems to be middle, but for combos that span three keys horizontally or vertically, this ends up covering other keys.
A top or left/right default alignment for those combos would be better.
Here is an image as an example:
The text was updated successfully, but these errors were encountered:
This has been something on my mind but I hadn't committed to handling these. Of course it's hard to get it perfect but we can add some heuristics to improve the default parse output. I can think of some rules like:
Equal horizontal coordinates for keys, more than one key gap: align: left or align: right depending on whether combo position is left or right of midpoint of layout
Equal vertical coordinates for keys, more than one key gap: align: top or align: bottom depending on whether combo position is higher or lower than midpoint of layout
However this is hard to do during parsing since we don't know about the physical layout at this point. This logic might need to be moved to drawing and override mid specification when it is not explicitly specified. We already do something similar for dendron field.
Then there is also the issue of combo boxes overlapping with other elements like the hold specs that sartak brought up here: #3 (comment) Unfortunately that is much harder to fix since it requires rethinking the drawing code so that keys/combos are not all independently drawn.
Currently, the alignment for all combos seems to be middle, but for combos that span three keys horizontally or vertically, this ends up covering other keys.
A top or left/right default alignment for those combos would be better.
Here is an image as an example:
![Screenshot 2023-03-02 at 14 14 57](https://user-images.githubusercontent.com/7404004/222542370-3fc82ff8-e6b3-4fe0-8f08-c0c0f7610b0c.png)
The text was updated successfully, but these errors were encountered: