Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Bug: Regression - Transit name is not bolded in agency links #2590

Closed
machikoyasuda opened this issue Dec 12, 2024 · 1 comment · Fixed by #2599
Closed

Bug: Regression - Transit name is not bolded in agency links #2590

machikoyasuda opened this issue Dec 12, 2024 · 1 comment · Fixed by #2599
Assignees
Labels
bug Something isn't working

Comments

@machikoyasuda
Copy link
Member

Image Image

The agency-links includes is used on the Help page and some of the agency-specific Error pages, as shown above in Figma screenshots.

The transit agency names are currently unbold on Dev, but they are bolded correctly on Prod. So we have a regression somewhere.
Image

@machikoyasuda machikoyasuda added the bug Something isn't working label Dec 12, 2024
@machikoyasuda machikoyasuda self-assigned this Dec 12, 2024
@machikoyasuda
Copy link
Member Author

Update: I figured out the cause of the bug. It's coming from removing the CA State Web Template, which gives us this:

.nav-media .subtitle,
label {
  font-weight:700;
}

I was also reading the HTML spec, which actually states that labels should only use for form fields, so this HTML element should be a span or p.

@machikoyasuda machikoyasuda moved this from Todo to In progress in Digital Services Dec 16, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in Digital Services Dec 19, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant