Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Break constants into types of constants #181

Open
ethanlee16 opened this issue Mar 22, 2018 · 0 comments
Open

Break constants into types of constants #181

ethanlee16 opened this issue Mar 22, 2018 · 0 comments
Labels
TechDebt

Comments

@ethanlee16
Copy link
Member

It might be a little confusing for a new developer to see ANSWER_FETCH_IN_PROGRESS vs. FETCH_IN_PROGRESS, as @kevintli pointed out. Break out constants into two types:

  • constants/fetchStatuses.js (is this a weird plural?) - for things like FETCH_IN_PROGRESS
  • constants/actionTypes.js - for things like ANSWER_FETCH_IN_PROGRESS, UPDATE_LOCAL_ANSWER
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
TechDebt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ethanlee16