After haul upgrade can't compile with TypeError: compilation.getAsset is not a function #652

TNorth22 · 2019-10-03T17:52:20Z

Environment

    "@haul-bundler/babel-preset-react-native": "^0.13.2",
    "@haul-bundler/cli": "^0.13.1",
    "@haul-bundler/inspector": "^0.13.0",
    "@haul-bundler/preset-0.60": "^0.13.0",
    "react-native": "^0.61.1",
     Node v10.16.0

Config:

// since preset-0.61 isn't yet available
import { withPolyfills, makeConfig } from '@haul-bundler/preset-0.60';

const removeRuleByTest = (moduleConfig, test) => {
  const index = moduleConfig.findIndex(rule => {
    if (rule.test) {
      return rule.test.toString() === test.toString();
    }
    return false;
  });
  moduleConfig.splice(index, 1);
};

export default makeConfig({
  bundles: {
    index: platform => ({
      entry: withPolyfills(`./src/index.${platform}.js`),
      transform({ config }) {
        // Remove babel-loader, as it handles both .ts(x) and .js(x) files
        removeRuleByTest(config.module.rules, /\.[jt]sx?$/);

        config.module.rules = [
          {
            exclude: /node_modules(?!.*[\/\\](react|@react-native-community|@haul-bundler))/,
            test: /\.tsx?$/,
            loader: 'ts-loader',
          },
          ...config.module.rules,

          // Re-add the babel-loader, now only for .js(x)
          {
            exclude: /node_modules(?!.*[\/\\](react|@react-native-community|@haul-bundler))/,
            test: /\.jsx?$/,
            loader: require.resolve('babel-loader'),
            options: {
              plugins: [require.resolve('@haul-bundler/core/build/utils/fixRequireIssues')],
            },
          },
          ...config.module.rules,
        ];

        config.resolve.extensions = [
          `.${platform}.ts`,
          '.mobile.ts',
          '.native.ts',
          `.${platform}.tsx`,
          '.mobile.tsx',
          '.native.tsx',
          '.ts',
          '.tsx',
          ...config.resolve.extensions,
        ];
      },
    }),
  },
});

Description

After upgrading to the new haul bundle from a working legacy instance and starting with a fresh config I seemingly can't exclude things from Typescript checks and compilation terminates. Not sure what I'm missing or am I looking at an outdated config?

Traviss-MacBook-Pro:xc **$ yarn ios --haul-inspector
yarn run v1.16.0
$ NODE_OPTIONS=--max_old_space_size=8192 REACT_NATIVE=true NODE_ENV=development yarn haul start --platform ios --eager ios --haul-inspector
[Logs]

done ▶︎ Packager server running on http://localhost:8081
error ▶︎ /Users/**/**/xc/node_modules/@haul-bundler/core/node_modules/webpack/lib/SourceMapDevToolPlugin.js:179
const asset = compilation.getAsset(file).source;


TypeError: compilation.getAsset is not a function
at files.forEach (/Users/**/**/xc/node_modules/@haul-bundler/core/node_modules/webpack/lib/SourceMapDevToolPlugin.js:179:33)
at Array.forEach (<anonymous>)
at compilation.hooks.afterOptimizeChunkAssets.tap (/Users/**/**/xc/node_modules/@haul-bundler/core/node_modules/webpack/lib/SourceMapDevToolPlugin.js:178:12)
at SyncHook.eval [as call] (eval at create (/Users/**/**/xc/node_modules/tapable/lib/HookCodeFactory.js:19:10), <anonymous>:12:1)
at SyncHook.lazyCompileHook (/Users/**/**/xc/node_modules/tapable/lib/Hook.js:154:20)
at hooks.optimizeChunkAssets.callAsync.err (/Users/**/**/xc/node_modules/webpack/lib/Compilation.js:1313:42)
at AsyncSeriesHook.eval [as callAsync] (eval at create (/Users/**/**/xc/node_modules/tapable/lib/HookCodeFactory.js:32:10), <anonymous>:9:1)
at AsyncSeriesHook.lazyCompileHook (/Users/**/**/xc/node_modules/tapable/lib/Hook.js:154:20)
at hooks.additionalAssets.callAsync.err (/Users/**/**/xc/node_modules/webpack/lib/Compilation.js:1309:36)
at AsyncSeriesHook.eval [as callAsync] (eval at create (/Users/**/**/xc/node_modules/tapable/lib/HookCodeFactory.js:32:10), <anonymous>:9:1)
at AsyncSeriesHook.lazyCompileHook (/Users/**/**/xc/node_modules/tapable/lib/Hook.js:154:20)
at hooks.optimizeTree.callAsync.err (/Users/**/**/xc/node_modules/webpack/lib/Compilation.js:1305:32)
at AsyncSeriesHook.eval [as callAsync] (eval at create (/Users/**/**/xc/node_modules/tapable/lib/HookCodeFactory.js:32:10), <anonymous>:9:1)
at AsyncSeriesHook.lazyCompileHook (/Users/**/**/xc/node_modules/tapable/lib/Hook.js:154:20)
at Compilation.seal (/Users/**/**/xc/node_modules/webpack/lib/Compilation.js:1242:27)
at hooks.make.callAsync.err (/Users/**/**/xc/node_modules/webpack/lib/Compiler.js:546:17)
at _err0 (eval at create (/Users/**/**/xc/node_modules/tapable/lib/HookCodeFactory.js:32:10), <anonymous>:11:1)
at _addModuleChain (/Users/**/**/xc/node_modules/webpack/lib/Compilation.js:1093:12)
at processModuleDependencies.err (/Users/**/**/xc/node_modules/webpack/lib/Compilation.js:1005:9)
at process._tickCallback (internal/process/next_tick.js:61:11)

Reproducible Demo

The text was updated successfully, but these errors were encountered:

zamotany · 2019-10-03T18:43:52Z

@TNorth22 I'll take a lot at this tomorrow. In the meantime, if it's possible for you, could you create a repro repository, which I could use for testing?

zamotany · 2019-10-07T13:33:38Z

@TNorth22 I cannot reproduce your issue. The config looks file apart from duplicated ...config.module.rules. The stack trace is pointing to a Webpack plugin for creating source maps, so you can try adding sourceMap: false to bundle config (index object in haul.config.js) just to check if that helps. Other than that, without a reproduction repo I cannot do much.

TNorth22 · 2019-10-08T00:14:44Z

Hey @zamotany thanks for the response. Just getting back from vacation today. Unfortunately I couldn't repro on a fresh rn project :-/.

sourceMap: false results in a slew of typescript errors so i don't think that's going to help.

I'll see if I can dig a little deeper and get some more info in the meantime.

zamotany · 2019-10-08T10:56:24Z

@TNorth22 setting sourceMap to false should not have any effect on loaders (and typescript compilation), which makes me think that maybe the underlying problem is with ts-loader/typescript.

Can you post those errors from typescript?
Did you tried haul bundle instead of start? Same results?

rebirthtobi · 2019-10-10T18:25:58Z

I'm also experiencing the same error, Also used haul bundle and i get the response

zamotany · 2019-10-11T09:17:04Z

@rebirthtobi Can you post your haul.config.js?

zamotany · 2019-10-14T15:33:06Z

@TNorth22 @rebirthtobi Can you add "resolution": { "webpack": "4.39.1" } to your package.json, do yarn install and check if the error is still occurring? Can you also try with "resolution": { "webpack": "4.41.1" }?

rebirthtobi · 2019-10-14T17:47:53Z

@zamotany i believe that fixes it but i'm faced with a new error
.babelrcRoots is not allowed in .babelrc or "extends"ed files, only in root programmatic options, or babel.config.js/config

pointing to @haul-bundler/preset-0.60/node_mudules/babel-loader/lib/index.js

zamotany · 2019-10-14T17:54:32Z

@rebirthtobi Can you post your Babel config file??

hjhart · 2019-10-14T22:37:07Z

Just as a note – taking the note from @zamotany above worked for us. There was a small typo, however, and it is:

"resolutions": { "webpack": "4.41.1" }

Noting that the key recommended above was resolution but should be resolutions.

Thanks!

zamotany · 2019-10-15T08:28:34Z

Ok, so this issue looks like it's caused by duplicated webpack depednency. I need a volunteer to:

Remove resolutions from package.json
yarn install
yarn list --pattern webpack
Paste the outout

@hjhart @TNorth22 @rebirthtobi

zamotany · 2019-10-15T08:29:48Z

@rebirthtobi I believe the issue with .babelrcRoots is connected with your Babel config. In haul we don't use/specify babelrcRoots.

hjhart · 2019-10-18T22:48:45Z

@zamotany

yarn list v1.15.2
├─ @haul-bundler/basic-bundle-webpack-plugin@0.13.0
├─ @haul-bundler/core@0.13.2
│  └─ webpack@4.41.2
├─ @haul-bundler/ram-bundle-webpack-plugin@0.13.0
├─ @rails/webpacker@4.0.7
│  ├─ webpack-cli@3.3.9
│  └─ webpack@4.41.2
├─ @storybook/core@3.4.11
│  ├─ uglifyjs-webpack-plugin@0.4.6
│  ├─ webpack-dev-middleware@1.12.2
│  └─ webpack@3.12.0
├─ @storybook/react@3.4.11
│  └─ webpack@3.12.0
│     └─ uglifyjs-webpack-plugin@0.4.6
├─ case-sensitive-paths-webpack-plugin@2.2.0
├─ compression-webpack-plugin@2.0.0
├─ dotenv-webpack@1.5.7
├─ html-webpack-plugin@2.30.1
├─ last-call-webpack-plugin@3.0.0
├─ optimize-css-assets-webpack-plugin@5.0.3
├─ pnp-webpack-plugin@1.5.0
├─ simple-progress-webpack-plugin@1.1.2
├─ terser-webpack-plugin@1.4.1
├─ uglifyjs-webpack-plugin@1.3.0
├─ voom@0.0.1
│  └─ webpack-cli@3.3.9
├─ webpack-assets-manifest@3.1.1
├─ webpack-cli@3.1.2
├─ webpack-dev-middleware@3.4.0
├─ webpack-dev-server@3.1.9
├─ webpack-hot-middleware@2.24.3
├─ webpack-log@2.0.0
├─ webpack-sources@1.4.3
└─ webpack@4.21.0
✨  Done in 2.10s.

EugenePisotsky · 2019-11-29T16:36:46Z

any updates? I have the same issue

zamotany · 2019-12-03T07:38:24Z

@EugenePisotsky There's no update. I cannot reproduce the issue. It seams it's connected with specific haul.config.js and/or duplicated webpack dependency, but without any repro I cannot do much. If you want to have this issue resolved, please try to create a repro project and post the link to it here.

DaveWelling · 2020-07-10T20:49:23Z

Future googlers - FWIW - I had this error and was able to resolve it by uninstalling webpack and webpack-cli, then installing the latest version of those two.

denieler · 2021-04-06T08:00:34Z

This issue was solved for me by upgrading webpack from 4.33 to 4.46 version. It looks like getAssets feature was added only in webpack version 4.40.

zamotany added the needs more info label Oct 7, 2019

zamotany added bug and removed needs more info labels Oct 15, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

After haul upgrade can't compile with TypeError: compilation.getAsset is not a function #652

After haul upgrade can't compile with TypeError: compilation.getAsset is not a function #652

TNorth22 commented Oct 3, 2019

zamotany commented Oct 3, 2019

zamotany commented Oct 7, 2019 •

edited

Loading

TNorth22 commented Oct 8, 2019

zamotany commented Oct 8, 2019

rebirthtobi commented Oct 10, 2019

zamotany commented Oct 11, 2019

zamotany commented Oct 14, 2019 •

edited

Loading

rebirthtobi commented Oct 14, 2019

zamotany commented Oct 14, 2019

hjhart commented Oct 14, 2019

zamotany commented Oct 15, 2019

zamotany commented Oct 15, 2019

hjhart commented Oct 18, 2019

EugenePisotsky commented Nov 29, 2019

zamotany commented Dec 3, 2019

DaveWelling commented Jul 10, 2020

denieler commented Apr 6, 2021

After haul upgrade can't compile with TypeError: compilation.getAsset is not a function #652

After haul upgrade can't compile with TypeError: compilation.getAsset is not a function #652

Comments

TNorth22 commented Oct 3, 2019

Environment

Description

Reproducible Demo

zamotany commented Oct 3, 2019

zamotany commented Oct 7, 2019 • edited Loading

TNorth22 commented Oct 8, 2019

zamotany commented Oct 8, 2019

rebirthtobi commented Oct 10, 2019

zamotany commented Oct 11, 2019

zamotany commented Oct 14, 2019 • edited Loading

rebirthtobi commented Oct 14, 2019

zamotany commented Oct 14, 2019

hjhart commented Oct 14, 2019

zamotany commented Oct 15, 2019

zamotany commented Oct 15, 2019

hjhart commented Oct 18, 2019

EugenePisotsky commented Nov 29, 2019

zamotany commented Dec 3, 2019

DaveWelling commented Jul 10, 2020

denieler commented Apr 6, 2021

zamotany commented Oct 7, 2019 •

edited

Loading

zamotany commented Oct 14, 2019 •

edited

Loading