Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Build docker images when PR changes them #1815

Closed
rachitnigam opened this issue Dec 18, 2023 · 1 comment · Fixed by #1824
Closed

Build docker images when PR changes them #1815

rachitnigam opened this issue Dec 18, 2023 · 1 comment · Fixed by #1824
Labels
C: Docker Related to the docker container S: Available Can be worked upon

Comments

@rachitnigam
Copy link
Contributor

This is an annoying problem that we keep running into where the docker image we use can be out of date from the one a PR is creating. @UnsignedByte added a hack in the Filament repo to check if the Dockerfile has changed and rebuild it if needed. We should copy that code into this repo as well.

@rachitnigam rachitnigam added S: Available Can be worked upon C: Docker Related to the docker container labels Dec 18, 2023
@sampsyo
Copy link
Contributor

sampsyo commented Dec 18, 2023

That would help a bit! One slightly "higher-coverage" option (that would not require explicitly hashing the Dockerfile) would be to just condition the Docker build on changes to certain paths directly. For example, this setup for the Bril repo only tries to build the docs if the docs have changed:
https://github.com/sampsyo/bril/blob/34133101a68bb50ae0fc8083857a3e3bd6bae260/.github/workflows/docs.yaml#L4-L9

We could do the same thing for the Docker image, conditioning it on Dockerfile and anything else that we think needs to bump the image (Cargo.lock?).

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
C: Docker Related to the docker container S: Available Can be worked upon
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants